From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 6BD71CE2D45; Thu, 22 Aug 2024 16:47:47 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6BD71CE2D45 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1724334467; bh=61WYU6mNMPSkY0UlkeYwiAtX31EfAo17BwsKwfw4FQQ=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=lUg2xMDvS1xRP7bgTwZ86BTt45oGD8CCYJn9dbM9kT8rHyr+QhcYzd5JSeolEW6e9 UZ/Afk2Mu3baD2MRvLl8fHv6JR3gUZmgXD3DzXOhKQ/40Gcc3jk9qpTB2HcXH0QyLA /6koCDlpgGnkss22lJj5DjCMOAmH9pf1/D2zza2c= Received: from smtp58.i.mail.ru (smtp58.i.mail.ru [95.163.41.96]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 2673ECE2D43 for ; Thu, 22 Aug 2024 16:47:46 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2673ECE2D43 Received: by smtp58.i.mail.ru with esmtpa (envelope-from ) id 1sh8AC-0000000HHwE-3IFo; Thu, 22 Aug 2024 16:47:45 +0300 Content-Type: multipart/alternative; boundary="------------Dq0nlcZ97jfm0YN7sev0UDV7" Message-ID: <58df164b-ebe1-4ebb-80ba-f8606ea3a1d6@tarantool.org> Date: Thu, 22 Aug 2024 16:47:44 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun , Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org References: <439d9b017029c16d49cb9cf40dec881d6a9697b3.1724228998.git.skaplun@tarantool.org> In-Reply-To: <439d9b017029c16d49cb9cf40dec881d6a9697b3.1724228998.git.skaplun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9BB2AFC06FD50F0EF98186F8875EB77F7A17BB3EFFBAEBB4D182A05F53808504059F7535319B523AF89CEA9C911D099959F6A67312B207E5782BBE18FB0487B480650F91B75C56BA3 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE78981306C6E927004EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC20F58FBAB79054EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38B043BF0FB74779F36E299AB71F331F113DABAE896EEC267315E69C450B54EB1B6A471835C12D1D9774AD6D5ED66289B5259CC434672EE6371117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE7ABB305BD10C6E5099FA2833FD35BB23DF004C90652538430302FCEF25BFAB3454AD6D5ED66289B5278DA827A17800CE7541FADD3D81556A7D32BA5DBAC0009BE395957E7521B51C2330BD67F2E7D9AF1090A508E0FED6299176DF2183F8FC7C087047FD9FF236CBACD04E86FAF290E2DB606B96278B59C421DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6F82A78844E5C6993089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A50938895E3DF094985002B1117B3ED69652F832B8A5E744CE9E040399BDE4761E823CB91A9FED034534781492E4B8EEAD85CCBA673D36D1A4BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF6DD753DF8BADF065C1E651FFF704CB9CFEEAFCDF70A1DEB7F13A855884E47A4E7E72D8710CBEBF0E2FB0CAD32ADFBF848AAB3B1B5FD975089CBCAF205E377A070CE1BB016CAC83C75F4332CA8FE04980913E6812662D5F2AB9AF64DB4688768036DF5FE9C0001AF333F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojbUwDRTee1XprJ9t30Bcptw== X-Mailru-Sender: 520A125C2F17F0B1E52FEF5D219D61405B4238F6C7278A4A3157D4372140BED1F7D3A118F7BC9DFA0152A3D17938EB451EB5A0BCEC6A560B3DDE9B364B0DF289BE2DA36745F2EEB5CEBA01FB949A1F1EEAB4BC95F72C04283CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 31/45] test: refactor LuaJIT test X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------Dq0nlcZ97jfm0YN7sev0UDV7 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sergey, On 21.08.2024 11:58, Sergey Kaplun wrote: > This patch refactors the aforementioned test to make its code style > closer to ours. > > Relates to tarantool/tarantool#9398 > --- thanks for the patch! LGTM with a minor: probably line 10 needs more whitespaces: >      do local a,b,c,d,e,f,g,h,i,j,k,l,m,n end -- Ensure bigger frame size. > test/LuaJIT-tests/lang/gc_stack.lua | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/test/LuaJIT-tests/lang/gc_stack.lua b/test/LuaJIT-tests/lang/gc_stack.lua > index cd3d8f90..8aee57e3 100644 > --- a/test/LuaJIT-tests/lang/gc_stack.lua > +++ b/test/LuaJIT-tests/lang/gc_stack.lua > @@ -1,5 +1,5 @@ > do --- Marking sparse stack. > - local t = setmetatable({}, { __index=function(t, k) > + local t = setmetatable({}, { __index = function(t, k) > k = k - 1 > if k == 0 then > collectgarbage() -- Mark stack, including holes. --------------Dq0nlcZ97jfm0YN7sev0UDV7 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Sergey,


On 21.08.2024 11:58, Sergey Kaplun wrote:
This patch refactors the aforementioned test to make its code style
closer to ours.

Relates to tarantool/tarantool#9398
---

thanks for the patch! LGTM with a minor:

probably line 10 needs more whitespaces:

>      do local a,b,c,d,e,f,g,h,i,j,k,l,m,n end -- Ensure bigger frame size.

 test/LuaJIT-tests/lang/gc_stack.lua | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/LuaJIT-tests/lang/gc_stack.lua b/test/LuaJIT-tests/lang/gc_stack.lua
index cd3d8f90..8aee57e3 100644
--- a/test/LuaJIT-tests/lang/gc_stack.lua
+++ b/test/LuaJIT-tests/lang/gc_stack.lua
@@ -1,5 +1,5 @@
 do --- Marking sparse stack.
-  local t = setmetatable({}, { __index=function(t, k)
+  local t = setmetatable({}, { __index = function(t, k)
     k = k - 1
     if k == 0 then
       collectgarbage() -- Mark stack, including holes.
--------------Dq0nlcZ97jfm0YN7sev0UDV7--