From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 78F446C7D2; Thu, 25 Feb 2021 15:43:17 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 78F446C7D2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1614256997; bh=4UJ/BD/z54PGOkEYLyVXpRhWY/SppOKOevsMGREZm1U=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=IDkF3KUZidnVog/rdPcdG1fht5QuYqfxwfVGEYBSj7jeLzkBUHYNhNzseZVRFIhnp fNd38jwxMA/VCLtFQXl0WY4rv2K8Tw2HnO6p7EiB/C8oRFhrvGRGHyCcr3QfQJiKgu tbxMTSK/abWE1YlGXNwt/ZVvjWZMgnIXM8MVdS5M= Received: from smtp49.i.mail.ru (smtp49.i.mail.ru [94.100.177.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B81AB6C7D2 for ; Thu, 25 Feb 2021 15:42:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B81AB6C7D2 Received: by smtp49.i.mail.ru with esmtpa (envelope-from ) id 1lFFyY-0007Fd-47; Thu, 25 Feb 2021 15:42:38 +0300 To: Vladislav Shpilevoy , tarantool-patches@dev.tarantool.org, yaroslav.dynnikov@tarantool.org References: <8be0f758-10ae-98e5-d6f5-359db7eaf7cd@tarantool.org> Message-ID: <58d756fd-62fa-95b3-6028-c80a73f520f3@tarantool.org> Date: Thu, 25 Feb 2021 15:42:37 +0300 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD975C3EC174F5669229511437AA01F46811CFCF616A939B362182A05F5380850403A31415B7739DEDD2E6F84C2BD0FAD933E907643AE2A1B5BC4001DFF27DA6E68 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7E50EC9128971FD6EEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006373768BF035B57E5168638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95CDDE882590F889B1C8F9FE0723E6DEF23D4B505DFE5DCB834A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE73AFA331E307B52169FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3FD59DAE6580CC3C3117882F4460429728AD0CFFFB425014E868A13BD56FB6657D81D268191BDAD3DC09775C1D3CA48CF0E6BD793C670A4DDBA3038C0950A5D36C8A9BA7A39EFB766EC990983EF5C0329BA3038C0950A5D36D5E8D9A59859A8B69DDE31049AE272CF76E601842F6C81A1F004C90652538430CDED94BCBF13EF3B93EC92FD9297F6718AA50765F7900637C69D4C8FA58DAC3AA7F4EDE966BC389F395957E7521B51C24C7702A67D5C33162DBA43225CD8A89FDD9D78FC367030856D8C47C27EEC5E9FB5C8C57E37DE458B4C7702A67D5C3316FA3894348FB808DB48C21F01D89DB561574AF45C6390F7469DAA53EE0834AAEE X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A24A6D60772A99906F8E1CD14B953EB46DCD7B3B5BACE0F1BE355D89D7DBCDD132 X-C1DE0DAB: 0D63561A33F958A5F31C4EDB1C66BADB56F86D46B7965572F1D8CC0B84BC5AE0D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7557E988E9157162368E8E86DC7131B365E7726E8460B7C23C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34C0DDD40374D35017435D7605FC03915BFF29FCB58CCCD6731E315AE5EF6BAE3E6B6DE6359CF4720C1D7E09C32AA3244CA063406ECDDB033E15BCFC6E6BFEF2A0F94338140B71B8EEFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojvz1c9SWJtj9/NbQHGyzMqg== X-Mailru-Sender: 583F1D7ACE8F49BD9317CE1922F30C7E92C40DE9FA26BF73C3DD99B4221CB0D55DEE61814008E47C23E75C7104EB1B885DEE61814008E47C7013064206BFB89F93956FB04BA385BE9437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH vshard 05/11] util: introduce safe fiber_cond_wait() X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Oleg Babin via Tarantool-patches Reply-To: Oleg Babin Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for your answer! On 25.02.2021 00:48, Vladislav Shpilevoy wrote: > Thanks for the review! > > On 24.02.2021 11:27, Oleg Babin wrote: >> Hi! Thanks for your patch. LGTM. >> >> I see several usages of cond:wait() in code. Maybe after introducing this helper you could use it. >> >> E.g. in "bucket_send_xc" function. > Yeah, I checked the existing usages, but it is fine as is > there. > > In bucket_send_xc() it is ok to throw. This is why it is 'xc' - > 'exception'. It is ok, because there are other ops which can > throw, and eventually I decided not to wrap them all into pcalls. > > In global fibers I kept the normal waits, because its throw here > is fine. They don't have any finalization work to do after the waits. Ok.