From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 703976BD0D; Sun, 11 Apr 2021 20:42:26 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 703976BD0D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1618162946; bh=sa9IvZKvhkDNBQZlJyZxSGEOue7QLqsFpXg+52vED9U=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=vaRM/D1QmyfnJtFF35lJt7v3i7X5wUf1AqrUImBCJLD9pyfOM1jY5tWhg4yUEo38W Zk2w96MZxjdt6sb2SFHhnE2/PtzfXULCkuUDRaIVUUTA440QQUEFyVz8dJPoj8lIga Orrex/akxRYCWlCGv9Kb+l8i+J7ACv9fXs8OtRhc= Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 274486BD0C for ; Sun, 11 Apr 2021 20:42:25 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 274486BD0C Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1lVe6J-00008q-Ut; Sun, 11 Apr 2021 20:42:24 +0300 To: imeevma@tarantool.org, tsafin@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: <3fda2029b186d0cea67ba01269dc3d6e209b3c89.1617984948.git.imeevma@gmail.com> Message-ID: <57dd6994-64f3-7645-f0ec-376751bd0b3e@tarantool.org> Date: Sun, 11 Apr 2021 19:42:22 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <3fda2029b186d0cea67ba01269dc3d6e209b3c89.1617984948.git.imeevma@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD92FFCB8E6708E7480EBD5CA77A668ECB87DA2124B0A8E6609182A05F538085040E3DA147C27E5104994369AF8064CB6C8570CC58919269D0D2F1F69530153DD7A X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE79145AB6E9E75F07EEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063727599E9BE65898D58638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B229C3C20673428446D24AF646E0BC3E503C8827A907CBE77DD2E47CDBA5A96583C09775C1D3CA48CF4964A708C60C975A117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE74601F13E4625331C9FA2833FD35BB23DF004C906525384302BEBFE083D3B9BA73A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E73542F54486E6D6388DC4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A53613C5B1B7135D9F6E33D1CBFB1B85BB1D6AD2B540831A87D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D344B4608D01B1CB59A766679AC414D9E163ECEA074C722A91D14F696F23D64C02CB6E16F25A7E1986B1D7E09C32AA3244C63A282CF723CB36D5E5408C2CD6B56EEBBA718C7E6A9E042FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojyKKJYJ15DtJ/7/YdgO4c+g== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822449521FAE4740790C0D25AD6E919290F3841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v5 01/52] sql: enhance vdbe_decode_msgpack_into_mem() X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Good job on the patch! On 09.04.2021 18:51, Mergen Imeev via Tarantool-patches wrote: > Hi! Thank you for the review! My answer and new patch below. I didn't include > diffs in answers since due to merge conflicts they are partly useless. > > On 30.03.2021 01:57, Vladislav Shpilevoy wrote: >> Hi! I appreciate the work you did here! >> >> Truly huge patch. But it does the important thing which I think >> should give a huge help in the task of SQL code rework. >> >> On 23.03.2021 10:34, Mergen Imeev via Tarantool-patches wrote: >>> Currently, vdbe_decode_msgpack_into_mem() creates a MEM that is not >>> properly initialized in case msgpack contains MP_EXT, MP_MAP, or >>> MP_ARRAY fields. Also, it doesn't set field_type. >> >> AFAIR, field type wasn't set deliberately. Because we use it only for >> strictly typed values obtained from formatted space fields. It wasn't >> applied to plain non-formatted values on purpose. >> >> Why do you change that? > > I didn't know about that. I thought that all MEMs that contains data should have > field_type set. However, I tried to understand where did this field come from > and found that it was added for two purposes: to show difference between NUMBER > and INTEGER in MEM before DOUBLE was added and to show column name instead of > type determined from MP-type in typeof(). I believe that both these purposes are > not needed now and that this field should be removed from struct MEM. I created > an issue for this: #5957. However, I was prohibited to remove this field for now > by @tsafin, who believes that this field is actually important. I tend to agree, that it must be done separately. Although probably could be done before this patchset to make it kind of simpler. Anyway, thanks for the explanation.