From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olegrok@tarantool.org>
Received: from smtp53.i.mail.ru (smtp53.i.mail.ru [94.100.177.113])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 639E346970E
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 14 Jan 2020 18:02:26 +0300 (MSK)
References: <20200110154805.94649-1-olegrok@tarantool.org>
 <20200114142136.GB547@tarantool.org>
From: Oleg Babin <olegrok@tarantool.org>
Message-ID: <5736c5c2-b38e-7642-5942-af466977d3b4@tarantool.org>
Date: Tue, 14 Jan 2020 18:02:25 +0300
MIME-Version: 1.0
In-Reply-To: <20200114142136.GB547@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v3] error: add __concat method to
	error object
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Sergey Ostanevich <sergos@tarantool.org>
Cc: Oleg Babin <babinoleg@mail.ru>, tarantool-patches@dev.tarantool.org

Thanks for your review!

Yes, you are right but I think that gereral cases have been covered for 
"box.error" type.


I've created an issue - 
https://github.com/tarantool/tarantool/issues/4725 to generalize such 
approach and may be add "__concat" for decimals/uuid/...


Also "decimals" is not available in 1.10 if we want to backport this 
patch one day


On 14/01/2020 17:21, Sergey Ostanevich wrote:
> Hi!
> 
> Thanks for the patch!
> 
> I wonder if you're interested in coverage of all Lua types in tests?
> On my side I found that decimals are not so fancy:

---
Oleg Babin