From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounces@dev.tarantool.org>
Received: from [87.239.111.99] (localhost [127.0.0.1])
	by dev.tarantool.org (Postfix) with ESMTP id 73F066EC55;
	Thu, 22 Jul 2021 02:24:33 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 73F066EC55
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev;
	t=1626909873; bh=c035as4d+CzcsR+whSBj1Cqyu4fhvxsoVDt4D5Fwnvg=;
	h=To:Cc:References:Date:In-Reply-To:Subject:List-Id:
	 List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:
	 From:Reply-To:From;
	b=V0dgjPLTcqfXcytXT3eDqKspkyJVJQphEvGgCp9sbx7Xq57JFXCHNA1cipoPK5iH6
	 3Z6TPuDayILsaPEDojSwTDmaPiLl32IYk0FJZbmO18+G3CWfXB5S4aGeuihY0lC9pS
	 VvQT0Xt9PGkmrES/Hk33rcBYW/7IKqeo/MKFqWcM=
Received: from smtpng1.i.mail.ru (smtpng1.i.mail.ru [94.100.181.251])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 1926B6EC55
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 22 Jul 2021 02:24:32 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1926B6EC55
Received: by smtpng1.m.smailru.net with esmtpa (envelope-from
 <v.shpilevoy@tarantool.org>)
 id 1m6LZn-0008Lp-6O; Thu, 22 Jul 2021 02:24:31 +0300
To: Serge Petrenko <sergepetrenko@tarantool.org>, gorcunov@gmail.com
Cc: tarantool-patches@dev.tarantool.org
References: <cover.1626287002.git.sergepetrenko@tarantool.org>
 <de13e1f50454b0cf2cbcd2cdfeb5082e36c55ee6.1626287002.git.sergepetrenko@tarantool.org>
Message-ID: <571af10d-1ce6-8f92-b5c2-48eafa3d7977@tarantool.org>
Date: Thu, 22 Jul 2021 01:24:30 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <de13e1f50454b0cf2cbcd2cdfeb5082e36c55ee6.1626287002.git.sergepetrenko@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-7564579A: 646B95376F6C166E
X-77F55803: 4F1203BC0FB41BD941C43E597735A9C30288BCF456A452EC92BAB6D044D5CCDE182A05F5380850408F7A0674A15ABD2EEBD1AA09A642104DAA95FBE7101EE12F047D024C9446EEDD
X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7D9C4478D0B876341EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375D8840FA58F505298638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8370F83443B0A2AB0DC10C03E6D15A141117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC8C7ADC89C2F0B2A5A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751FF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8BDCE939D40DBB93CA75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356
X-C1DE0DAB: 0D63561A33F958A5B8BFDCCA72F7DE553C820F5B03C6E88243EA8080C4ADCE6BD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7501A9DF589746230F410CA545F18667F91A7EA1CDA0B5A7A0
X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D349F4E6BC39AAD02BB2BF8817A2DC3D37007DEE45F959484F1751BA3970F54E6B1AC6A45380F78887D1D7E09C32AA3244C169B8D0A1CBA1F7AA3B5F16AAD78571264EE5813BBCA3A9DFACE5A9C96DEB163
X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojaAaPr+N/4d18nJSBX9NrtQ==
X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D5338DF682F0C0A735E6921A003EAE10A3841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B
X-Mras: Ok
Subject: Re: [Tarantool-patches] [PATCH v4 06/16] replication: send latest
 effective promote in initial join
X-BeenThere: tarantool-patches@dev.tarantool.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
From: Vladislav Shpilevoy via Tarantool-patches
 <tarantool-patches@dev.tarantool.org>
Reply-To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Errors-To: tarantool-patches-bounces@dev.tarantool.org
Sender: "Tarantool-patches" <tarantool-patches-bounces@dev.tarantool.org>

Hi! Good job on the patch!

> diff --git a/src/box/relay.cc b/src/box/relay.cc
> index 4ebe0fb06..4b102a777 100644
> --- a/src/box/relay.cc
> +++ b/src/box/relay.cc
> @@ -442,7 +445,11 @@ relay_initial_join(int fd, uint64_t sync, struct vclock *vclock,
>  		row.type = IPROTO_JOIN_META;
>  		coio_write_xrow(&relay->io, &row);
>  
> -		/* Empty at the moment. */
> +		char body[XROW_SYNCHRO_BODY_LEN_MAX];
> +		xrow_encode_synchro(&row, body, &req);
> +		row.replica_id = req.replica_id;
> +		row.sync = sync;

Shouldn't we also attach sync to IPROTO_JOIN_SNAPSHOT and
IPROTO_JOIN_META? Although I don't see where it is used in
the applier. But I see it is attached to xrow_encode_vclock
a bit above.