From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 3C16C15D1105; Mon, 17 Nov 2025 17:00:19 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3C16C15D1105 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1763388019; bh=PyqTVw5QSgv4zJS4HRxVNYBHT1HILPapvDYYUPZb34U=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=Jk6n4V/3IXmYhtR/TsPIBBNsLoRrt9yT3UUz+mM35slCB+2fkAzgStpZZ4r+UtH0X bu9/SUKPvOKGD8qzCIZLHXOkKpT6fA4yLTnSA8u5qpf0+ySHxVsjGsZnK+SBtNH14Z ssPGU0ef5XtivY2JQN24TLnmJOPXtkIB0VKShwfM= Received: from send196.i.mail.ru (send196.i.mail.ru [95.163.59.35]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 8FE82158B381 for ; Mon, 17 Nov 2025 16:59:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8FE82158B381 Received: by exim-smtp-88cf54d45-ts29n with esmtpa (envelope-from ) id 1vKzl5-00000000CVm-2twe; Mon, 17 Nov 2025 16:59:08 +0300 Content-Type: multipart/alternative; boundary="------------0kLYEyaIRnDsV2joCNqT6Crs" Message-ID: <56e2a46b-f7e8-48b7-93cb-f847d410f96e@tarantool.org> Date: Mon, 17 Nov 2025 16:59:07 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org References: <17ef4a5a33c093f30c0b45dcf0833dbf81b75191.1761301736.git.skaplun@tarantool.org> In-Reply-To: <17ef4a5a33c093f30c0b45dcf0833dbf81b75191.1761301736.git.skaplun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9110BAFCBE6BD1D1673EE44C5E0B5084E363170F60A2E3EF3182A05F538085040837CBA69592C85773DE06ABAFEAF6705DD367AB937567CE2D487FD47310B043B39C31E52C72DD4EE X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE741DC22BF90A736D8EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB55337566D0BE23D09F2BEA50E1632385ED29E0529AA43C40E0FCAB9EE0BAE5B881075155389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C07E7E81EEA8A9722B8941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B64854413538E1713FCC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C224958C1606C78F2434E76E601842F6C81A12EF20D2F80756B5FB606B96278B59C4276E601842F6C81A127C277FBC8AE2E8B6A4E49BB0F3BA1413AA81AA40904B5D99C9F4D5AE37F343AD1F44FA8B9022EA23BBE47FD9DD3FB595F5C1EE8F4F765FC72CEEB2601E22B093A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E7356436AE5DD6441DC7C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A559EDEC74B169D3255002B1117B3ED6962C0BAB9CCB758AB214DB8790748E3E77823CB91A9FED034534781492E4B8EEAD9CFA8CFAC159CE19BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF79E0152C5ACE8958280B867B869A6CB076E45EE9067486FE8D27704A997773F1696309706696DB62DD12B02666E493560759C7CF8441BBC25FBE7F2EAD842E4A4D7F9C762ED6EE02111DC66A97D0BFE2913E6812662D5F2AB9AF64DB4688768036DF5FE9C0001AF333F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVfFX+FmbwDW1+aflNAQofDM= X-Mailru-Sender: 520A125C2F17F0B1A9638AD358559B59306A3B92B45DBF913DE06ABAFEAF6705DD367AB937567CE2B7CBEF92542CD7C8795FA72BAB74744FC77752E0C033A69EA16A481184E8BB1C9B38E6EA4F046BE03A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 luajit 26/41] perf: adjust revcomp in LuaJIT-benches X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------0kLYEyaIRnDsV2joCNqT6Crs Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Sergey, thanks for the patch! See my comments. Sergey On 10/24/25 13:50, Sergey Kaplun wrote: > This patch adjusts the aforementioned test to use the benchmark > framework introduced before. The default arguments are adjusted > according to the file. The arguments to the script still > can be provided in the command line run. > > The benchmark input is given by redirecting the corresponding > file generated by the `libs/fasta.lua 5e6`. The output > from the benchmark is redirected to /dev/null. Checks are skipped since > the output is very huge, and it is overkill to store it in the > repository. > --- > perf/LuaJIT-benches/revcomp.lua | 72 +++++++++++++++++++++------------ > 1 file changed, 47 insertions(+), 25 deletions(-) > > diff --git a/perf/LuaJIT-benches/revcomp.lua b/perf/LuaJIT-benches/revcomp.lua > index 34fe347b..2b1ffa5c 100644 > --- a/perf/LuaJIT-benches/revcomp.lua > +++ b/perf/LuaJIT-benches/revcomp.lua > @@ -1,3 +1,4 @@ > +local bench = require("bench").new(arg) > > local sub = string.sub > iubc = setmetatable({ > @@ -9,29 +10,50 @@ iubc = setmetatable({ > }, { __index = function(t, s) > local r = t[sub(s, 2)]..t[sub(s, 1, 1)]; t[s] = r; return r end }) > > -local wcode = [=[ > -return function(t, n) > - if n == 1 then return end > - local iubc, sub, write = iubc, string.sub, io.write > - local s = table.concat(t, "", 1, n-1) > - for i=#s-59,1,-60 do > - write(]=] > -for i=59,3,-4 do wcode = wcode.."iubc[sub(s, i+"..(i-3)..", i+"..i..")], " end > -wcode = wcode..[=["\n") > - end > - local r = #s % 60 > - if r ~= 0 then > - for i=r,1,-4 do write(iubc[sub(s, i-3 < 1 and 1 or i-3, i)]) end > - write("\n") > - end > -end > -]=] > -local writerev = loadstring(wcode)() > +local stdout = io.output() > > -local t, n = {}, 1 > -for line in io.lines() do > - local c = sub(line, 1, 1) > - if c == ">" then writerev(t, n); io.write(line, "\n"); n = 1 > - elseif c ~= ";" then t[n] = line; n = n + 1 end > -end > -writerev(t, n) > +bench:add({ > + name = "revcomp", > + -- The compare with the result output file is inconvenient. > + skip_check = true, > + setup = function() > + io.output("/dev/null") > + end, > + payload = function() > + local wcode = [=[ > + return function(t, n) > + if n == 1 then return end > + local iubc, sub, write = iubc, string.sub, io.write > + local s = table.concat(t, "", 1, n-1) > + for i=#s-59,1,-60 do > + write(]=] > + for i=59,3,-4 do wcode = wcode.."iubc[sub(s, i+"..(i-3)..", i+"..i..")], " end > + wcode = wcode..[=["\n") > + end > + local r = #s % 60 > + if r ~= 0 then > + for i=r,1,-4 do write(iubc[sub(s, i-3 < 1 and 1 or i-3, i)]) end > + write("\n") > + end > + end > + ]=] > + local writerev = loadstring(wcode)() > + > + local t, n = {}, 1 > + for line in io.lines() do > + local c = sub(line, 1, 1) > + if c == ">" then writerev(t, n); io.write(line, "\n"); n = 1 > + elseif c ~= ";" then t[n] = line; n = n + 1 end > + end > + writerev(t, n) > + -- Repeat operation several times. > +io.stdin:seek("set", 0) > + end, > + teardown = function() > + io.output(stdout) > + end, > + -- Amount of symbols in the input file. > + items = 5e6, > +}) > + > +bench:run_and_report() --------------0kLYEyaIRnDsV2joCNqT6Crs Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi, Sergey,

thanks for the patch! See my comments.

Sergey

On 10/24/25 13:50, Sergey Kaplun wrote:
This patch adjusts the aforementioned test to use the benchmark
framework introduced before. The default arguments are adjusted
according to the <PARAM_x86.txt> file. The arguments to the script still
can be provided in the command line run.

The benchmark input is given by redirecting the corresponding
<FASTA_5000000> file generated by the `libs/fasta.lua 5e6`. The output
from the benchmark is redirected to /dev/null. Checks are skipped since
the output is very huge, and it is overkill to store it in the
repository.
---
 perf/LuaJIT-benches/revcomp.lua | 72 +++++++++++++++++++++------------
 1 file changed, 47 insertions(+), 25 deletions(-)

diff --git a/perf/LuaJIT-benches/revcomp.lua b/perf/LuaJIT-benches/revcomp.lua
index 34fe347b..2b1ffa5c 100644
--- a/perf/LuaJIT-benches/revcomp.lua
+++ b/perf/LuaJIT-benches/revcomp.lua
@@ -1,3 +1,4 @@
+local bench = require("bench").new(arg)
 
 local sub = string.sub
 iubc = setmetatable({
@@ -9,29 +10,50 @@ iubc = setmetatable({
 }, { __index = function(t, s)
   local r = t[sub(s, 2)]..t[sub(s, 1, 1)]; t[s] = r; return r end })
 
-local wcode = [=[
-return function(t, n)
-  if n == 1 then return end
-  local iubc, sub, write = iubc, string.sub, io.write
-  local s = table.concat(t, "", 1, n-1)
-  for i=#s-59,1,-60 do
-    write(]=]
-for i=59,3,-4 do wcode = wcode.."iubc[sub(s, i+"..(i-3)..", i+"..i..")], " end
-wcode = wcode..[=["\n")
-  end
-  local r = #s % 60
-  if r ~= 0 then
-    for i=r,1,-4 do write(iubc[sub(s, i-3 < 1 and 1 or i-3, i)]) end
-    write("\n")
-  end
-end
-]=]
-local writerev = loadstring(wcode)()
+local stdout = io.output()
 
-local t, n = {}, 1
-for line in io.lines() do
-  local c = sub(line, 1, 1)
-  if c == ">" then writerev(t, n); io.write(line, "\n"); n = 1
-  elseif c ~= ";" then t[n] = line; n = n + 1 end
-end
-writerev(t, n)
+bench:add({
+  name = "revcomp",
+  -- The compare with the result output file is inconvenient.
+  skip_check = true,
+  setup = function()
+    io.output("/dev/null")
+  end,
+  payload = function()
+    local wcode = [=[
+    return function(t, n)
+      if n == 1 then return end
+      local iubc, sub, write = iubc, string.sub, io.write
+      local s = table.concat(t, "", 1, n-1)
+      for i=#s-59,1,-60 do
+        write(]=]
+    for i=59,3,-4 do wcode = wcode.."iubc[sub(s, i+"..(i-3)..", i+"..i..")], " end
+    wcode = wcode..[=["\n")
+      end
+      local r = #s % 60
+      if r ~= 0 then
+        for i=r,1,-4 do write(iubc[sub(s, i-3 < 1 and 1 or i-3, i)]) end
+        write("\n")
+      end
+    end
+    ]=]
+    local writerev = loadstring(wcode)()
+
+    local t, n = {}, 1
+    for line in io.lines() do
+      local c = sub(line, 1, 1)
+      if c == ">" then writerev(t, n); io.write(line, "\n"); n = 1
+      elseif c ~= ";" then t[n] = line; n = n + 1 end
+    end
+    writerev(t, n)
+    -- Repeat operation several times.
+    io.stdin:seek("set", 0)
+  end,
+  teardown = function()
+    io.output(stdout)
+  end,
+  -- Amount of symbols in the input file.
+  items = 5e6,
+})
+
+bench:run_and_report()
--------------0kLYEyaIRnDsV2joCNqT6Crs--