From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id F1AE1F45B30; Mon, 24 Feb 2025 21:06:52 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org F1AE1F45B30 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1740420413; bh=u3rywWTvBqPZ4Zxh9eUGnGNVO1p3RRLr0kjioGF4RtI=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=PyO/N889GXQMAtBLFkjGjSJKfTeaw1tcTRvWe0R4NwQwOKdh77WUfpWaTS0/fy5Pa M/ElG34CWcOsYrXHaevIoidGFQqfzYS7/dBp1OLeMZ8v2rp9FRL4+Cdq/WX9T3pZbi ksSZvLOYLjUsyyDKxLQ71rhAgWab0jvsLOhpp/AY= Received: from send105.i.mail.ru (send105.i.mail.ru [89.221.237.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 729E4F45B2E for ; Mon, 24 Feb 2025 21:06:51 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 729E4F45B2E Received: by exim-smtp-75f5fcb77d-gm4rk with esmtpa (envelope-from ) id 1tmcqv-00000000EI5-449J; Mon, 24 Feb 2025 21:06:50 +0300 Content-Type: multipart/alternative; boundary="------------HCyPxelnTjBVzqzSIKucQd0P" Message-ID: <56c145e4-df05-4882-be1f-c387b120e977@tarantool.org> Date: Mon, 24 Feb 2025 21:06:50 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun , Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org References: <6990a0f3b661498e2c4c7697f5da4cfe4e35ffe4.1740050074.git.sergeyb@tarantool.org> In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD957BCB5CA1E0F722C6853C33931886B2BB01D76CB6CB1FB15182A05F538085040A3E20C50F4A0951C3DE06ABAFEAF670595AE9103139748722308A7AB66F554E5B14F0FA0E0289DA8 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE771540F9ECFC94C4BEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637C867FEFF36BCDF178638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8A413F515E0609F165313273E60168994A9A47225D7CDB15ACC7F00164DA146DAFE8445B8C89999728AA50765F7900637F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F79006372A3B24BF85B2E607389733CBF5DBD5E9B5C8C57E37DE458BD9DD9810294C998ED8FC6C240DEA76428AA50765F7900637F24693029971C26FD32BA5DBAC0009BE395957E7521B51C2330BD67F2E7D9AF1090A508E0FED6299176DF2183F8FC7C02AE38A8E97BAFFB1B3661434B16C20ACC84D3B47A649675FE827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8BA56E11165BA017C7EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5BF8E400283FEBE5A5002B1117B3ED696369F595FF7DBF99172305013E4AE841E823CB91A9FED034534781492E4B8EEADC0A73878EBD0941BBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D342F9EE325F82A28A82BD8DADF54EB012F8438E455A39EDA64BF27D392E2747776574EF8B4F64A37BF1D7E09C32AA3244C7E4003E70B95E76E77DD89D51EBB7742F760A285C8B4B87AEA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59978A700BF655EAEEED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVQQG/FugD0/Cgy0mTFRI310= X-Mailru-Sender: C4F68CFF4024C8867DFDF7C7F258845801FD9C30403803AD6750B362712FA5BDB32A2B26F154E66BBFC4D249E1BCDA0D645D15D82EE4B272BD6E4642A116CA93524AA66B5ACBE6721EF430B9A63E2A504198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 5/8][v3] test: introduce flag LUAJIT_DISABLE_MEMPROF X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------HCyPxelnTjBVzqzSIKucQd0P Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Sergey, thanks for review! Updated and force-pushed. Sergey On 24.02.2025 12:45, Sergey Kaplun via Tarantool-patches wrote: > Hi, Sergey! > Thanks for the fixes! > LGTM, except a few nits regarding the commit message. > > On 20.02.25, Sergey Bronnikov wrote: >> The patch introduce an environment variable LUAJIT_DISABLE_MEMPROF > Typo: s/introduce/introduces/ Fixed. > > >> needed by tests in suite `tarantool-tests` for skip testcases when > Typo: s/suite/the suite/ > Typo: s/for skip/to skip/ Fixed. >> memprof is disabled in build. > Typo: s/build/the build/ Fixed. > >> Needed for the following commit. >> --- > > --------------HCyPxelnTjBVzqzSIKucQd0P Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi, Sergey,

thanks for review!

Updated and force-pushed.

Sergey

On 24.02.2025 12:45, Sergey Kaplun via Tarantool-patches wrote:
Hi, Sergey!
Thanks for the fixes!
LGTM, except a few nits regarding the commit message.

On 20.02.25, Sergey Bronnikov wrote:

The patch introduce an environment variable LUAJIT_DISABLE_MEMPROF

Typo: s/introduce/introduces/
Fixed.



needed by tests in suite `tarantool-tests` for skip testcases when

Typo: s/suite/the suite/
Typo: s/for skip/to skip/
Fixed.

      

        
memprof is disabled in build.


      

      
Typo: s/build/the build/

    

    Fixed.

    

      



      

        
Needed for the following commit.
---


      

      
<snipped>



    

  
  


--------------HCyPxelnTjBVzqzSIKucQd0P--