From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id D2CF87030F; Fri, 15 Jan 2021 15:56:28 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D2CF87030F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1610715388; bh=8BxCEwWAutKZRl1YqXkKIQFwrI+mvG3XC5y8qetLAf0=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=xGssCofw91E4K+TLZp759bxHtA3CBKEguuqYydqKmWHQ8564aRyp1bMH1Pe3iYX/h U1Bv9nIi0q7Ujd1PtkXWy6zT7mVCe/4Vdd+XPoasbXhZWAGw13k43GmTcUdfHEAy8/ W7lm8jyceXgsFJxo9kYAAngzZsbzGAQHnPKAezpM= Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 901CC7030F for ; Fri, 15 Jan 2021 15:56:27 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 901CC7030F Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1l0OeQ-0006tg-SF; Fri, 15 Jan 2021 15:56:27 +0300 To: Serge Petrenko , tarantool-patches@dev.tarantool.org Cc: v.shpilevoy@tarantool.org References: Message-ID: <5665f0ed-0b99-d974-044b-60865a856c6d@tarantool.org> Date: Fri, 15 Jan 2021 15:56:26 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9D0E79FBC973162CDAC53986DC5FB1AB1465E8C05863AF8B800894C459B0CD1B94C1F19DC72F0F591EDC5FECA15D0807D02587BF5ABB16BCD03D3BFA7FB8E1556 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE72E4E5201E1C2E308EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006370CE92FB8C11ED3D88638F802B75D45FF5571747095F342E8C7A0BC55FA0FE5FC6FD3D10E84685BD8BC1BD062583E42CA75E1B034ACAED1FD389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C091DAD9F922AA71188941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6A50BD5087FBFCDAACC7F00164DA146DA6F5DAA56C3B73B23C77107234E2CFBA567F23339F89546C55F5C1EE8F4F765FCD13596CABAF710B375ECD9A6C639B01BBD4B6F7A4D31EC0BC0CAF46E325F83A522CA9DD8327EE4931B544F03EFBC4D57463FC242DBD691A6C4224003CC836476C0CAF46E325F83A50BF2EBBBDD9D6B0F05F538519369F3743B503F486389A921A5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A58E3317F76EEF52256FA21A85528FBE9F57C7AC85EC779914D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA758F9E841AEAEC4F2C410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34AC6E62257D6CD1C9F2478BC61454C070AD149F95D8C21FB3DA1F8F814AE0E69290B6008932F726841D7E09C32AA3244C06DD6610ADAA50CDED70F601CC8EE09F35DA7DC5AF9B58C0FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojT/h6YDL0UQ4V/j30figHeg== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822D4053EC5BD77565544DC8D517F94583DDD788429FD8613638ED9BB8B05EE7B3AFB559BB5D741EB96D19CD4E7312BAA970A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 2/2] luacheck: fix warnings in test/box-tap X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for review! On 15.01.2021 15:40, Serge Petrenko wrote: > > > 15.01.2021 14:22, sergeyb@tarantool.org пишет: >> From: Sergey Bronnikov >> >> Follows up #5457 >> --- >>   test/box-tap/feedback_daemon.test.lua | 6 +++--- >>   1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/test/box-tap/feedback_daemon.test.lua >> b/test/box-tap/feedback_daemon.test.lua >> index 123033cda..8cfbf31d7 100755 >> --- a/test/box-tap/feedback_daemon.test.lua >> +++ b/test/box-tap/feedback_daemon.test.lua >> @@ -124,8 +124,8 @@ local fh = fio.open("feedback.json") >>   test:ok(fh, "file is created") >>   local file_data = fh:read() >>   -- Ignore the report time. The data should be equal other than that. >> -feedback_save = string.gsub(feedback_save, 'time:(%d+)', 'time:0') >> -file_data = string.gsub(feedback_save, 'time:(%d+)', 'time:0') >> +feedback_save = string.gsub(feedback_save, '"time":(%d+)', 'time:0') >> +file_data = string.gsub(file_data, '"time":(%d+)', 'time:0') > Thanks for finding this typo! > Please also replace `time:0` with `"time":0` Sure. @@ -124,8 +124,8 @@ local fh = fio.open("feedback.json")  test:ok(fh, "file is created")  local file_data = fh:read()  -- Ignore the report time. The data should be equal other than that. -feedback_save = string.gsub(feedback_save, '"time":(%d+)', 'time:0') -file_data = string.gsub(file_data, '"time":(%d+)', 'time:0') +feedback_save = string.gsub(feedback_save, '"time":(%d+)', '"time":0') +file_data = string.gsub(file_data, '"time":(%d+)', '"time":0')  test:is(file_data, feedback_save, "data is equal")  fh:close()  fio.unlink("feedback.json") > > Other than that LGTM. > >>   test:is(file_data, feedback_save, "data is equal") >>   fh:close() >>   fio.unlink("feedback.json") >> @@ -247,7 +247,7 @@ box.space.features_memtx_empty:drop() >>   box.space.features_memtx:drop() >>   box.space.features_sync:drop() >>   -function check_stats(stat) >> +local function check_stats(stat) >>       local sub = test:test('feedback operation stats') >>       sub:plan(18) >>       local box_stat = box.stat() >