From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp55.i.mail.ru (smtp55.i.mail.ru [217.69.128.35])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 0338C4696C5
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 15 Apr 2020 02:30:22 +0300 (MSK)
References: <cover.1586849129.git.sergeyb@tarantool.org>
 <df73ea556e3a8c7558abf7dd91150b07daed6eb6.1586849129.git.sergeyb@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <562140a0-b397-5666-7f7b-20c5540adaee@tarantool.org>
Date: Wed, 15 Apr 2020 01:30:20 +0200
MIME-Version: 1.0
In-Reply-To: <df73ea556e3a8c7558abf7dd91150b07daed6eb6.1586849129.git.sergeyb@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 4/6] Fix luacheck warnings in
 extra/dist/tarantoolctl.in
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Sergey Bronnikov <sergeyb@tarantool.org>, tarantool-patches@dev.tarantool.org, avtikhon@tarantool.org, alexander.turenko@tarantool.org, o.piskunov@tarantool.org

Thanks for the patch!

Consider more fixes below and on the branch in a separate commit.
That allowed to remove some warning mutes from the luacheck
config.

====================

    Review fixes: tarantoolctl.in

diff --git a/extra/dist/tarantoolctl.in b/extra/dist/tarantoolctl.in
index d7f098735..b8e8d0632 100755
--- a/extra/dist/tarantoolctl.in
+++ b/extra/dist/tarantoolctl.in
@@ -132,7 +132,8 @@ local function load_default_file(default_file)
             log.error("Failed to load defaults file: %s", msg)
         end
         debug.setfenv(ufunc, env)
-        local state, msg = pcall(ufunc)
+        local state
+        state, msg = pcall(ufunc)
         if not state then
             log.error('Failed to execute defaults file: %s', msg)
         end