From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 3ECD13052C for ; Fri, 31 May 2019 09:45:29 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WpsrlJhX8Q_e for ; Fri, 31 May 2019 09:45:29 -0400 (EDT) Received: from smtp43.i.mail.ru (smtp43.i.mail.ru [94.100.177.103]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 0320830132 for ; Fri, 31 May 2019 09:45:27 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v4 1/4] schema: add new system space for CHECK constraints References: <6780ecce-2186-9f6c-6b4e-133ad98ddafa@tarantool.org> <37f6781a-1317-bca3-5c08-c2b67fc45073@tarantool.org> From: Kirill Shcherbatov Message-ID: <55fc4271-76fb-0b06-acd1-2f16c4a6728f@tarantool.org> Date: Fri, 31 May 2019 16:45:25 +0300 MIME-Version: 1.0 In-Reply-To: <37f6781a-1317-bca3-5c08-c2b67fc45073@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org, Vladislav Shpilevoy > Somewhy you trimmed the context, but here it is again: > > "we create a list of a new ck constraints objects" > > You wrote "a new ck constraints objects". Firstly, "a objects" > is incorrect. Secondly, if you want to describe an object as > purposed to something, you do not need plural. It should be > > "we create a list of new ck constraint objects" > > "constraints" -> "constraint", it is like an adjective here. > "a objects" -> "objects". You can't use 'a' with plural. Fixed. >>> 8. We already have ADD CONSTRAINT. It works for FK, UNIQUE, PK. The >>> problem is that we can't call it on a non-empty space. >> https://github.com/tarantool/tarantool/issues/4243 > > My comment was rather about incorrect comment - "ADD CONSTRAINT" > is already implemented, but here you state, that it is not so. The > comment is still incorrect. Ok, now it is /* * FIXME: Ck constraint creation on non-empty * space is not implemented yet. */