From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 752FB469719
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 11 Mar 2020 03:17:35 +0300 (MSK)
References: <cover.1583689251.git.v.shpilevoy@tarantool.org>
 <52f89e63f044680d79f212ac91513c3738b8f1f6.1583689251.git.v.shpilevoy@tarantool.org>
 <20200310134250.GB26141@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <55b7ae51-ddd9-cdce-ddc5-3c0e30942842@tarantool.org>
Date: Wed, 11 Mar 2020 01:17:33 +0100
MIME-Version: 1.0
In-Reply-To: <20200310134250.GB26141@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 1/3] box: fix struct port_tuple.size
	wrong type in Lua
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org



On 10/03/2020 14:42, Nikita Pettik wrote:
> On 08 Mar 18:47, Vladislav Shpilevoy wrote:
>> Original port_tuple in C has 'int size;' field. It was
>> 'size_t size' in Lua. Since sizeof(size_t) usually is
>> 8, and sizeof(int) is 4, this was a really bad typo.
> 
> LGTM (feel free to push out of order as obvious).

Done. Pushed to master, 2.3, 2.2, 1.10.