Tarantool development patches archive
 help / color / mirror / Atom feed
From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
To: Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH v1] test: fix hang of vinyl/gh-4810-dump-during* test
Date: Mon,  9 Nov 2020 16:35:04 +0300	[thread overview]
Message-ID: <55a359863869f8dbf0ee0cea4676b9f4d5c6cef6.1604928833.git.avtikhon@tarantool.org> (raw)

During testing process:

  https://gitlab.com/tarantool/tarantool/-/jobs/800798411#L5693

found that test vinyl/gh-4810-dump-during-index-build.test.lua hanged:

  --- vinyl/gh-4810-dump-during-index-build.result		Tue Oct 20 08:41:33 2020
  +++ var/031_vinyl/gh-4810-dump-during-index-build.result	Fri May 8 08:23:45 2020
  @@ -117,34 +117,3 @@
   for i = 1, ch:size() do
       ch:get()
   end;
  - | ---
  - | ...
  -

This issue stops the testing till the complete timeout of the test-run
will stop all the testing process. To avoid of it 'wait_cond()' routine
was added to 'ch:get()' command to set it's local timeout to avoid of
waiting for test-run global timeout.

Needed for #5508
---

Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-5508-hang-gh-4810
Issue: https://github.com/tarantool/tarantool/issues/5508

 test/vinyl/gh-4810-dump-during-index-build.result   | 2 +-
 test/vinyl/gh-4810-dump-during-index-build.test.lua | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/test/vinyl/gh-4810-dump-during-index-build.result b/test/vinyl/gh-4810-dump-during-index-build.result
index f55c44a1f..ceb098c02 100644
--- a/test/vinyl/gh-4810-dump-during-index-build.result
+++ b/test/vinyl/gh-4810-dump-during-index-build.result
@@ -115,7 +115,7 @@ stop = true;
  | ---
  | ...
 for i = 1, ch:size() do
-    ch:get()
+    test_run:wait_cond(function() return ch:get() end)
 end;
  | ---
  | ...
diff --git a/test/vinyl/gh-4810-dump-during-index-build.test.lua b/test/vinyl/gh-4810-dump-during-index-build.test.lua
index 7b7026498..13b3d5a2a 100644
--- a/test/vinyl/gh-4810-dump-during-index-build.test.lua
+++ b/test/vinyl/gh-4810-dump-during-index-build.test.lua
@@ -61,7 +61,7 @@ fiber.sleep(3);
 
 stop = true;
 for i = 1, ch:size() do
-    ch:get()
+    test_run:wait_cond(function() return ch:get() end)
 end;
 
 test_run:cmd("setopt delimiter ''");
-- 
2.25.1

                 reply	other threads:[~2020-11-09 13:35 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55a359863869f8dbf0ee0cea4676b9f4d5c6cef6.1604928833.git.avtikhon@tarantool.org \
    --to=avtikhon@tarantool.org \
    --cc=kyukhin@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH v1] test: fix hang of vinyl/gh-4810-dump-during* test' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox