From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 3FDE127372 for ; Sat, 14 Apr 2018 04:14:58 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oh4SvDJVhbKP for ; Sat, 14 Apr 2018 04:13:37 -0400 (EDT) Received: from smtp32.i.mail.ru (smtp32.i.mail.ru [94.100.177.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 88AC325E73 for ; Sat, 14 Apr 2018 04:13:35 -0400 (EDT) From: "n.pettik" Message-Id: <55BEE14D-0F45-4DBD-95BB-D5EC23F02F18@tarantool.org> Content-Type: multipart/alternative; boundary="Apple-Mail=_7736561A-A5EE-45AF-88FE-8B664BE4194F" Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: [tarantool-patches] Re: [PATCH 2/2] sql: statistics removal after dropping an index Date: Sat, 14 Apr 2018 11:13:24 +0300 In-Reply-To: References: <1522791436-8221-1-git-send-email-hollow653@gmail.com> <926E041C-FCCB-46B0-B49B-21292CB70813@tarantool.org> <4E93854E-25F3-45F7-8590-5CD96991E365@tarantool.org> <51BFB6B0-C9CE-4380-8758-7F991512A752@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Hollow111 Cc: tarantool-patches@freelists.org --Apple-Mail=_7736561A-A5EE-45AF-88FE-8B664BE4194F Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 14 Apr 2018, at 07:29, Hollow111 wrote: >=20 > Hello. I'd like to ask about 'one kind of corrections=E2=80=9D. >=20 > Arguments which you carry to the next line, should start right below = previous: >=20 > void f(x int, =E2=80=A6. > y char, =E2=80=A6. > z double =E2=80=A6); >=20 > I couldnt find this in "C style guide" = (https://tarantool.io/en/doc/2.0/dev_guide/c_style_guide.html = ) > Moreover according to this guide: > "Outside of comments, documentation and except in Kconfig, spaces are = never used for indentation...". > Which means we're supposed to violate this rule In fact, they are used. Probably, we should update and clarify this = point in docs. You use tabs as much as possible. To precisely align argument lists, you = have to use spaces: return_value very_long_function_name_bla_bla_bla(int first_argument, int second_argument) To make =E2=80=99second_argument=E2=80=99 be under first, you should use = 8 tabs + 1 space. Overall, you can inspect other source files from box/ to understand how source files should be formatted. Also, I advise you to make spaces and = tabs visible. For instance, see how it was done in box/space.c 106 : space_create() > in case first argument is positioned not on the same range=20 > from left corner of screen as any amount of 8-character tabs.=20 > Maybe I'm wrong at smth but I'd like to have an explanation. --Apple-Mail=_7736561A-A5EE-45AF-88FE-8B664BE4194F Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8
On 14 Apr 2018, at 07:29, Hollow111 <hollow653@gmail.com>= wrote:

Hello. I'd like to ask about = 'one kind of corrections=E2=80=9D.


Arguments which you carry to the next line, should start = right below previous:

void f(x int, =E2=80=A6= .
          y char, =E2=80=A6.
          z double =E2=80=A6);

I couldnt find this in  "C style = guide" (https://tarantool.io/en/doc/2.0/dev_guide/c_style_guide.html)
Moreover according to this = guide:
"Outside of comments, documentation and = except in Kconfig, spaces are never used for indentation...".
Which means we're supposed to violate this = rule



in case first = argument is positioned not on the same range 
from left corner of screen as any amount of 8-character = tabs. 
Maybe I'm wrong at smth but I'd like to = have an explanation.

= --Apple-Mail=_7736561A-A5EE-45AF-88FE-8B664BE4194F--