From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 5F96A24596
	for <tarantool-patches@freelists.org>; Mon, 15 Jul 2019 13:50:40 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id Af5Z5Sj_FuRe for <tarantool-patches@freelists.org>;
	Mon, 15 Jul 2019 13:50:40 -0400 (EDT)
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id C34162458A
	for <tarantool-patches@freelists.org>; Mon, 15 Jul 2019 13:50:39 -0400 (EDT)
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\))
Subject: [tarantool-patches] Re: [PATCH v3 1/4] sql: remove unnecessary
 AUTOINCREMENT ID generation
From: "n.pettik" <korablev@tarantool.org>
In-Reply-To: <89267d98f7f336a5c76fd72e3888b83954b32f45.1562832978.git.imeevma@gmail.com>
Date: Mon, 15 Jul 2019 20:50:36 +0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <55B5738A-FBB8-47E9-87F5-FA558ADAA785@tarantool.org>
References: <cover.1562832978.git.imeevma@gmail.com>
 <89267d98f7f336a5c76fd72e3888b83954b32f45.1562832978.git.imeevma@gmail.com>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: Imeev Mergen <imeevma@tarantool.org>


>>> src/box/sql/insert.c                    |  5 +----
>>> test/sql/gh-2981-check-autoinc.result   | 32 =
++++++++++++++++++++++++++++++++
>>> test/sql/gh-2981-check-autoinc.test.lua | 11 ++++++++++-
>>> 3 files changed, 43 insertions(+), 5 deletions(-)
>>>=20
>>> diff --git a/src/box/sql/insert.c b/src/box/sql/insert.c
>>> index b353148..d2b4e17 100644
>>> --- a/src/box/sql/insert.c
>>> +++ b/src/box/sql/insert.c
>>> @@ -628,10 +628,7 @@ sqlInsert(Parse * pParse,	/* Parser =
context */
>>> 			if (j < 0 || nColumn =3D=3D 0
>>> 			    || (pColumn && j >=3D pColumn->nId)) {
>>> 				if (i =3D=3D (int) autoinc_fieldno) {
>>> -					sqlVdbeAddOp2(v,
>>> -							  =
OP_NextAutoincValue,
>>> -							  =
space->def->id,
>>> -							  iRegStore);
>>=20
>> Why didn=E2=80=99t you delete OP_NextAutioncValue?
>>=20
> I changed it functionality in the next patch.

You changes affect more than 50% of opcode's content.
Please, to make patches well structured, remove opcode
in current patch and resurrect in the next one.