From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp58.i.mail.ru (smtp58.i.mail.ru [217.69.128.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 5CB3B46970E for ; Mon, 27 Jan 2020 23:26:03 +0300 (MSK) Received: by smtp58.i.mail.ru with esmtpa (envelope-from ) id 1iwAxO-0003TZ-RT for tarantool-patches@dev.tarantool.org; Mon, 27 Jan 2020 23:26:03 +0300 From: Georgy Kirichenko Date: Mon, 27 Jan 2020 23:26:02 +0300 Message-ID: <5597526.lOV4Wx5bFT@localhost> In-Reply-To: <20200127193320.33773-1-georgy@tarantool.org> References: <20200127193320.33773-1-georgy@tarantool.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart4561263.31r3eYUQgx"; micalg="pgp-sha256"; protocol="application/pgp-signature" Subject: Re: [Tarantool-patches] [PATCH] region: take allocated region size instead of used one List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: tarantool-patches@dev.tarantool.org --nextPart4561263.31r3eYUQgx Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sorry, I forgot an issue and a branch. Issue: https://github.com/tarantool/tarantool/issues/4736 Branch: https://github.com/tarantool/tarantool/tree/g.kirichenko/gh-4736-region-size-for-gc Also the branch was repushed because of wrong rebase. On Monday, 27 January 2020 22:33:20 MSK Georgy Kirichenko wrote: > As region has cached but not used slabs take the full region size > in account while fiber gc. > > Fixes #4736 > > diff --git a/src/lib/core/fiber.c b/src/lib/core/fiber.c > index 00ae8cded..f795dc566 100644 > --- a/src/lib/core/fiber.c > +++ b/src/lib/core/fiber.c > @@ -774,7 +774,7 @@ fiber_self() > void > fiber_gc(void) > { > - if (region_used(&fiber()->gc) < 128 * 1024) { > + if (region_total(&fiber()->gc) < 128 * 1024) { > region_reset(&fiber()->gc); > return; > } --nextPart4561263.31r3eYUQgx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEECXG+Yw5ArYcP8x5wDVHWG5PoUw4FAl4vR1oACgkQDVHWG5Po Uw5yjwf/ZBZq/yuDXxyRnk5WYTFLpPWUep0+uUQt84bWRos+TzdiN6PXUzWtHMJZ Y+YXHdiaLd/Meg3ViNrzFG+NnprlPizHMx/I00K7X0gk73imqsSW3Ydt1FZl92Ye /0k3s8de0uWlISJRdCbcPW+aUA2asqc7hxQBLd84J2yN8pzIqrM7wd6el9Qh32mo xQ3ah7b0f3swJ9zm615C0p5Q4m3pmMII5JXTIFUAasvwWH4H2vMNSdhRngXMO9gk 9ZbqSZQG2YfJKR4sn05ZnTBjFrkSriyy8nHeEhvCbx9dbE6bJ95brjpAvbKvsTQy 6Ipit/N3zPFz7VT+vfMF2ilr/l1HjA== =Q6rz -----END PGP SIGNATURE----- --nextPart4561263.31r3eYUQgx--