From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Sergey Petrenko Message-Id: <549AA3E3-5195-4BD6-BCA8-3A9978449C76@tarantool.org> Content-Type: multipart/alternative; boundary="Apple-Mail=_DFA8C984-DAFF-4A2F-AD22-902E3F6B65BC" Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: [tarantool-patches] [PATCH] replication: fix a failing assert in replica_on_applier_disconnect() Date: Wed, 8 Aug 2018 18:19:03 +0300 In-Reply-To: <20180808105830.razslkg6whxzbcvq@esperanza> References: <20180803055905.69108-1-sergepetrenko@tarantool.org> <20180803155745.tmndjr52n6igtdno@tarantool.org> <81999702-C603-423E-92C9-199CE605FED4@tarantool.org> <20180807165031.e2avj7waurok3zpk@esperanza> <51F21380-A795-4F40-B3DE-A9770B190BD6@tarantool.org> <20180808105830.razslkg6whxzbcvq@esperanza> To: Vladimir Davydov Cc: Kirill Yukhin , tarantool-patches@freelists.org List-ID: --Apple-Mail=_DFA8C984-DAFF-4A2F-AD22-902E3F6B65BC Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > 8 =D0=B0=D0=B2=D0=B3. 2018 =D0=B3., =D0=B2 13:58, Vladimir Davydov = =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0= ): >=20 > On Wed, Aug 08, 2018 at 01:10:30PM +0300, Sergey Petrenko wrote: >>=20 >>=20 >>> 7 =D0=B0=D0=B2=D0=B3. 2018 =D0=B3., =D0=B2 19:50, Vladimir Davydov = =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0= ): >>>=20 >>> On Mon, Aug 06, 2018 at 05:14:05PM +0300, Sergey Petrenko wrote: >>>> diff --git a/test/replication/misc.test.lua = b/test/replication/misc.test.lua >>>> index c05e52165..27c1a4821 100644 >>>> --- a/test/replication/misc.test.lua >>>> +++ b/test/replication/misc.test.lua >>>> @@ -81,3 +81,15 @@ test_run:cmd("switch default") >>>> test_run:drop_cluster(SERVERS) >>>>=20 >>>> box.schema.user.revoke('guest', 'replication') >>>> + >>>> +-- gh-3510 assertion failure in replica_on_applier_disconnect() >>>> +test_run:cmd('create server er_load1 with = script=3D"replication/er_load1.lua"') >>>> +test_run:cmd('create server er_load2 with = script=3D"replication/er_load2.lua"') >>>> +test_run:cmd('start server er_load1 with wait=3DFalse, = wait_load=3DFalse') >>>> +test_run:cmd('start server er_load2 with wait=3DFalse, = wait_load=3DFalse') >>>> +require('fiber').sleep(0.5) >>>> +test_run:cmd('stop server er_load1') >>>> +require('fiber').sleep(1) >>>=20 >>> >>> These sleep()'s are way too long. They will make our tests run = forever. >>> Please change to 0.00001 or smaller or rewrite the test so that you = do >>> not need them. >>> >>=20 >> Hi! Thank you for review. >> Fixed. Here=E2=80=99s the new diff: >>=20 >> src/box/replication.cc | 4 ++++ >> test/replication/er_load.lua | 25 +++++++++++++++++++++++++ >> test/replication/er_load1.lua | 1 + >> test/replication/er_load2.lua | 1 + >> test/replication/misc.result | 32 ++++++++++++++++++++++++++++++++ >> test/replication/misc.test.lua | 12 ++++++++++++ >> 6 files changed, 75 insertions(+) >> create mode 100644 test/replication/er_load.lua >> create mode 120000 test/replication/er_load1.lua >> create mode 120000 test/replication/er_load2.lua >>=20 >=20 > With your patch replication/on_replace test hangs on Travis CI for > test/coverage targets (I tried to restart, but it doesn't help). > Actually, it hangs on my local machine too (debug build). Please fix. Hi! This happens due to a bug in test-run. I filed a ticket (https://github.com/tarantool/test-run/issues/109 = ). When it=E2=80=99s fixed, my test should pass no problem. So we have to = wait for now. --Apple-Mail=_DFA8C984-DAFF-4A2F-AD22-902E3F6B65BC Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8

8 =D0=B0=D0=B2=D0=B3. 2018 =D0=B3., =D0=B2 13:58, Vladimir = Davydov <vdavydov.dev@gmail.com> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0= =B0=D0=BB(=D0=B0):

On Wed, Aug = 08, 2018 at 01:10:30PM +0300, Sergey Petrenko wrote:


7 =D0=B0=D0= =B2=D0=B3. 2018 =D0=B3., =D0=B2 19:50, Vladimir Davydov <vdavydov.dev@gmail.com> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0= =B0=D0=BB(=D0=B0):

On Mon, Aug 06, 2018 at = 05:14:05PM +0300, Sergey Petrenko wrote:
diff --git a/test/replication/misc.test.lua = b/test/replication/misc.test.lua
index = c05e52165..27c1a4821 100644
--- = a/test/replication/misc.test.lua
+++ = b/test/replication/misc.test.lua
@@ -81,3 +81,15 @@ = test_run:cmd("switch default")
test_run:drop_cluster(SERVERS)

box.schema.user.revoke('guest', 'replication')
+
+-- gh-3510 assertion failure in = replica_on_applier_disconnect()
+test_run:cmd('create = server er_load1 with script=3D"replication/er_load1.lua"')
+test_run:cmd('create server er_load2 with = script=3D"replication/er_load2.lua"')
+test_run:cmd('start = server er_load1 with wait=3DFalse, wait_load=3DFalse')
+test_run:cmd('start server er_load2 with wait=3DFalse, = wait_load=3DFalse')
+require('fiber').sleep(0.5)
+test_run:cmd('stop server er_load1')
+require('fiber').sleep(1)

<kostja-mode>
These sleep()'s are way too = long. They will make our tests run forever.
Please change = to 0.00001 or smaller or rewrite the test so that you do
not= need them.
</kostja-mode>

Hi! Thank you for review.
Fixed. Here=E2=80=99s the new diff:

src/box/replication.cc =         |  4 ++++
test/replication/er_load.lua   | 25 = +++++++++++++++++++++++++
test/replication/er_load1.lua =  |  1 +
test/replication/er_load2.lua  | =  1 +
test/replication/misc.result   | 32 = ++++++++++++++++++++++++++++++++
test/replication/misc.test.lua | 12 ++++++++++++
6 files changed, 75 insertions(+)
create mode = 100644 test/replication/er_load.lua
create mode 120000 = test/replication/er_load1.lua
create mode 120000 = test/replication/er_load2.lua


With your patch replication/on_replace test hangs on Travis = CI for
test/coverage = targets (I tried to restart, but it doesn't help).
Actually, it hangs on my local = machine too (debug build). Please fix.
Hi! This = happens due to a bug in test-run.
When it=E2=80=99s fixed, my test should pass no problem. So we have to = wait for now.
= --Apple-Mail=_DFA8C984-DAFF-4A2F-AD22-902E3F6B65BC--