> 8 авг. 2018 г., в 13:58, Vladimir Davydov написал(а): > > On Wed, Aug 08, 2018 at 01:10:30PM +0300, Sergey Petrenko wrote: >> >> >>> 7 авг. 2018 г., в 19:50, Vladimir Davydov написал(а): >>> >>> On Mon, Aug 06, 2018 at 05:14:05PM +0300, Sergey Petrenko wrote: >>>> diff --git a/test/replication/misc.test.lua b/test/replication/misc.test.lua >>>> index c05e52165..27c1a4821 100644 >>>> --- a/test/replication/misc.test.lua >>>> +++ b/test/replication/misc.test.lua >>>> @@ -81,3 +81,15 @@ test_run:cmd("switch default") >>>> test_run:drop_cluster(SERVERS) >>>> >>>> box.schema.user.revoke('guest', 'replication') >>>> + >>>> +-- gh-3510 assertion failure in replica_on_applier_disconnect() >>>> +test_run:cmd('create server er_load1 with script="replication/er_load1.lua"') >>>> +test_run:cmd('create server er_load2 with script="replication/er_load2.lua"') >>>> +test_run:cmd('start server er_load1 with wait=False, wait_load=False') >>>> +test_run:cmd('start server er_load2 with wait=False, wait_load=False') >>>> +require('fiber').sleep(0.5) >>>> +test_run:cmd('stop server er_load1') >>>> +require('fiber').sleep(1) >>> >>> >>> These sleep()'s are way too long. They will make our tests run forever. >>> Please change to 0.00001 or smaller or rewrite the test so that you do >>> not need them. >>> >> >> Hi! Thank you for review. >> Fixed. Here’s the new diff: >> >> src/box/replication.cc | 4 ++++ >> test/replication/er_load.lua | 25 +++++++++++++++++++++++++ >> test/replication/er_load1.lua | 1 + >> test/replication/er_load2.lua | 1 + >> test/replication/misc.result | 32 ++++++++++++++++++++++++++++++++ >> test/replication/misc.test.lua | 12 ++++++++++++ >> 6 files changed, 75 insertions(+) >> create mode 100644 test/replication/er_load.lua >> create mode 120000 test/replication/er_load1.lua >> create mode 120000 test/replication/er_load2.lua >> > > With your patch replication/on_replace test hangs on Travis CI for > test/coverage targets (I tried to restart, but it doesn't help). > Actually, it hangs on my local machine too (debug build). Please fix. Hi! This happens due to a bug in test-run. I filed a ticket (https://github.com/tarantool/test-run/issues/109 ). When it’s fixed, my test should pass no problem. So we have to wait for now.