From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 8818942EF5C
 for <tarantool-patches@dev.tarantool.org>;
 Sat, 20 Jun 2020 02:49:28 +0300 (MSK)
References: <cover.1591345474.git.runsfor@gmail.com>
 <ef0528997c2d120730f40af9f6d70c7bd2db08c1.1591345474.git.runsfor@gmail.com>
 <67c75c01-8503-2355-e1f7-9644def2179c@tarantool.org>
 <EE69E031-21CF-49AC-89CE-8E57CB006E84@gmail.com>
 <6b8b0f63-0a3f-d3ae-7596-2611ea433d44@tarantool.org>
 <6D02837E-BBEB-4CB9-806F-D5D8E66014B1@gmail.com>
 <e1376d40-2d36-119d-d237-d53e64b28d23@tarantool.org>
 <8DEA1673-33E4-4930-9C61-45DEC371FE73@gmail.com>
 <642b3dbc-98f1-e09a-a71c-f94b8a6091cc@tarantool.org>
 <7425E178-64A5-4D73-860D-3D5BD0C95CF5@gmail.com>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <5480098d-e807-e360-4ab7-1feb41447000@tarantool.org>
Date: Sat, 20 Jun 2020 01:49:26 +0200
MIME-Version: 1.0
In-Reply-To: <7425E178-64A5-4D73-860D-3D5BD0C95CF5@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 2/2] feedback: collect db engines
	and index features
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: =?UTF-8?B?0JjQu9GM0Y8g0JrQvtC90Y7RhdC+0LI=?= <runsfor@gmail.com>
Cc: tarantool-patches@dev.tarantool.org

> diff --git a/test/box-tap/feedback_daemon.test.lua b/test/box-tap/feedback_daemon.test.lua
> index d4adb71f1..1fd5778b4 100755
> --- a/test/box-tap/feedback_daemon.test.lua
> +++ b/test/box-tap/feedback_daemon.test.lua
> @@ -115,21 +115,89 @@ check("feedback after feedback send_test")
>  
>  daemon.stop()
>  
> +actual = daemon.generate_feedback()
>  box.feedback.save("feedback.json")
>  local fio = require("fio")
>  local fh = fio.open("feedback.json")
>  test:ok(fh, "file is created")
>  local file_data = fh:read()
> -test:is(file_data, feedback_save, "data is equal")
> +test:is(file_data, json.encode(actual), "data is equal")
>  fh:close()
>  fio.unlink("feedback.json")
>  
>  server:close()
>  -- check it does not fail without server
> -local daemon = box.internal.feedback_daemon
> +daemon = box.internal.feedback_daemon

This diff hunk is not related to the patch. I reverted it
and the test passed.