From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 351E925024 for ; Thu, 15 Aug 2019 22:32:58 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xNDGEjZP2V7Y for ; Thu, 15 Aug 2019 22:32:58 -0400 (EDT) Received: from smtp3.mail.ru (smtp3.mail.ru [94.100.179.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id E883C25158 for ; Thu, 15 Aug 2019 22:32:57 -0400 (EDT) From: Alexander Turenko Subject: [tarantool-patches] [PATCH 1/2] lua: workaround pwd.getpwall() issue on Fedora 29 Date: Fri, 16 Aug 2019 05:32:35 +0300 Message-Id: <543c1b3b3d93460a3ff7184f96e8482dbc435849.1565920130.git.alexander.turenko@tarantool.org> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: Georgy Kirichenko Cc: Alexander Turenko , tarantool-patches@freelists.org, "Alexander V . Tikhonov" , Mergen Imeev This is a workaround for systemd-nss issue: https://github.com/systemd/systemd/issues/9585 The following error is observed on app-tap/pwd.test.lua on Fedora 29 (glibc-2.28-26.fc29, systemd-239-12.git8bca462.fc29) when tarantool is linked with libcurl w/o GSS-API support: | builtin/pwd.lua:169: getpwall failed [errno 2]: No such file or directory Such tarantool build lacks of libselinux.so.1 transitive dependency (tarantool -> libcurl.so.4 -> libgssapi_krb5.so.2 -> libkrb5support.so.0 -> libselinux.so.1) and strace shows the following calls when pwd.getpwall() is invoked first time: | openat(AT_FDCWD, "/lib64/libselinux.so.1", O_RDONLY|O_CLOEXEC) = 7A | <...> | access("/etc/selinux/config", F_OK) = -1 ENOENT (No such file or directory) It looks like a part of libselinux initialization code and is invoked during execution of a last ffi.C.getpwent() call that returns `nil` as a result and left errno set to ENOENT. Our pwd module set errno to zero before getpwent() call and expects that it will be preserved if no unrecoverable errors occur. It seems that this expectation is not meet due to the systemd-nss issue linked above. Second and next getpwall() calls will succeed, so the commit adds an extra getpwall() during pwd module load. This workaround is disabled on FreeBSD due to another issue: #4428 ('getpwall() hangs on FreeBSD 12'). See also the previous related commit: efccac691a4609c11f555a11704e91af4cda0836 ('lua: fix error handling in getpwall and getgrall'). Follows up #3766. Part of #4318. --- src/lua/pwd.lua | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/src/lua/pwd.lua b/src/lua/pwd.lua index 58c2e94f3..b6de1562f 100644 --- a/src/lua/pwd.lua +++ b/src/lua/pwd.lua @@ -194,6 +194,19 @@ local function getgrall() return grs end +-- Workaround pwd.getpwall() issue on Fedora 29: successful +-- getgrent() call that should normally return NULL and preserve +-- errno, set it to ENOENT due to systemd-nss issue [1] when a +-- password database is traversed first time. +-- +-- [1]: https://github.com/systemd/systemd/issues/9585 +-- +-- It is disabled on FreeBSD due to gh-4428: getpwall() hangs on +-- FreeBSD 12. +if jit.os ~= 'BSD' then + pcall(getpwall) +end + return { getpw = getpw, getgr = getgr, -- 2.22.0