From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp43.i.mail.ru (smtp43.i.mail.ru [94.100.177.103])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id DFA3A41C5DB
 for <tarantool-patches@dev.tarantool.org>;
 Wed,  1 Jul 2020 00:23:21 +0300 (MSK)
References: <20200611151853.24398-1-roman.habibov@tarantool.org>
 <20200611151853.24398-2-roman.habibov@tarantool.org>
 <e9ec1678-a48a-fe61-8ed0-bfb34f938df1@tarantool.org>
 <b1f19857-21bf-7a21-f870-aab9086a2f22@tarantool.org>
 <e1e9043a-e48f-97f8-2ec5-71791537b50d@tarantool.org>
 <81127D96-BB22-4F99-A788-047F9327A4AE@tarantool.org>
 <3e040934-d6dc-200b-5925-04879fea3e83@tarantool.org>
 <E2127215-5EF3-4315-9A05-262D3AC83783@tarantool.org>
 <b73befda-b7f4-5e6c-beb3-2af17b839397@tarantool.org>
 <0B6AD22C-DC0E-441C-B84E-9667A0AED2C3@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <54353233-4232-5964-414d-2115f18b2ac1@tarantool.org>
Date: Tue, 30 Jun 2020 23:23:18 +0200
MIME-Version: 1.0
In-Reply-To: <0B6AD22C-DC0E-441C-B84E-9667A0AED2C3@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v3 1/2] sql: use unify pattern for
 column names
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Roman Khabibov <roman.habibov@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi! Thanks for the fixes!

> +test:do_execsql2_test(
> +    "colname-12.5",
> +    [[
> +        CREATE TABLE j (s1 SCALAR PRIMARY KEY);
> +        INSERT INTO j VALUES(1);
> +    ]], {})
> +
> +--
> +-- Column named as 'COLUMN_1', because 's1 + 1' is a expression.
> +--
> +test:do_execsql2_test(
> +    "colname-12.6",
> +    [[
> +        SELECT s1 + 1 FROM j;
> +    ]], {
> +        "COLUMN_1",2
> +    })
> +
> +test:do_execsql2_test(
> +    "colname-12.7",
> +    [[
> +        SELECT s1 + 1 FROM j ORDER BY column_1;
> +    ]], {
> +        "COLUMN_1",2
> +    })
> +
> +test:do_execsql2_test(
> +    "colname-12.8",
> +    [[
> +        SELECT * FROM (SELECT s1 + 1 FROM j
> +                       ORDER BY column_1) ORDER BY column_1;
> +    ]], {
> +        "COLUMN_1",2
> +    })
> +
> +test:do_execsql2_test(
> +    "colname-12.9",
> +    [[
> +        SELECT s1 + 1 FROM j GROUP BY column_1;
> +    ]], {
> +        "COLUMN_1",2
> +    })
> +
> +test:do_execsql2_test(
> +    "colname-12.10",
> +    [[
> +        SELECT * FROM (SELECT s1 + 1 FROM j
> +                       ORDER BY column_1) GROUP BY column_1;
> +    ]], {
> +        "COLUMN_1",2
> +    })
> +
> +test:do_execsql2_test(
> +    "colname-12.11",
> +    [[
> +        SELECT * FROM (SELECT s1 + 1 FROM j
> +                       ORDER BY column_1) WHERE column_1 = 2;
> +    ]], {
> +        "COLUMN_1",2
> +    })
> +
> +test:do_execsql2_test(
> +    "colname-12.12",
> +    [[
> +        SELECT *, s1 + 1 FROM j ORDER BY column_1;
> +    ]], {
> +        "S1",1,"COLUMN_1",2
> +    })
> +
> +test:do_execsql2_test(
> +    "colname-12.13",
> +    [[
> +        SELECT s1 + 1, * FROM j ORDER BY column_1;
> +    ]], {
> +        "COLUMN_1",2,"S1",1
> +    })
> +
> +test:do_execsql2_test(
> +    "colname-12.14",
> +    [[
> +        CREATE TABLE j_1 (column_1 SCALAR PRIMARY KEY, column_2 SCALAR);
> +        INSERT INTO j_1 VALUES(1, 1);
> +    ]], {})
> +
> +test:do_execsql2_test(
> +    "colname-12.15",
> +    [[
> +        SELECT column_1, column_1 + 1, column_2, 2 FROM j_1;
> +    ]], {
> +        "COLUMN_1",1,"COLUMN_1",2,"COLUMN_2",1,"COLUMN_2",2
> +    })
> +

Is there a test on how ORDER BY selects a column?