From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [217.69.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id BF55F469710 for ; Tue, 12 May 2020 23:53:59 +0300 (MSK) References: From: Vladislav Shpilevoy Message-ID: <541acd38-a41a-a3c5-33ce-8146eadb65cc@tarantool.org> Date: Tue, 12 May 2020 22:53:57 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH 0/2] Fix crash in case of lack of FDs during recovery List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikita Pettik , tarantool-patches@dev.tarantool.org Hi! Thanks for the patchset and the fixes! LGTM. On 30/04/2020 21:27, Nikita Pettik wrote: > Branch: https://github.com/tarantool/tarantool/commits/np/gh-4805-too-many-fds > Issue: https://github.com/tarantool/tarantool/issues/4805 > > First patch adds simple macro which allows error injection to be delayed. > It also can be used in this series: > https://lists.tarantool.org/pipermail/tarantool-patches/2020-April/016367.html > > Nikita Pettik (2): > errinj: introduce delayed injection > vinyl: drop wasted runs in case range recovery fails > > src/box/vy_lsm.c | 14 ++- > src/box/vy_run.c | 4 + > src/errinj.h | 10 ++ > test/box/errinj.result | 1 + > test/vinyl/errinj_recovery.lua | 10 ++ > .../gh-4805-open-run-err-recovery.result | 101 ++++++++++++++++++ > .../gh-4805-open-run-err-recovery.test.lua | 38 +++++++ > test/vinyl/suite.ini | 2 +- > 8 files changed, 176 insertions(+), 4 deletions(-) > create mode 100644 test/vinyl/errinj_recovery.lua > create mode 100644 test/vinyl/gh-4805-open-run-err-recovery.result > create mode 100644 test/vinyl/gh-4805-open-run-err-recovery.test.lua >