From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 94B3A469719
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 15 Oct 2020 02:50:42 +0300 (MSK)
References: <20201013133418.34422-1-sergepetrenko@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <53c790b8-188c-d59e-a682-153ad0b51793@tarantool.org>
Date: Thu, 15 Oct 2020 01:50:40 +0200
MIME-Version: 1.0
In-Reply-To: <20201013133418.34422-1-sergepetrenko@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH] feedback_daemon: add synchro
 replication usage reporting
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Serge Petrenko <sergepetrenko@tarantool.org>, kyukhin@tarantool.org
Cc: tarantool-patches@dev.tarantool.org

Hi! Thanks for the patch!

See 2 comments below.

> diff --git a/test/box-tap/feedback_daemon.test.lua b/test/box-tap/feedback_daemon.test.lua
> index a04995d8a..c1ae5f81b 100755
> --- a/test/box-tap/feedback_daemon.test.lua
> +++ b/test/box-tap/feedback_daemon.test.lua
> @@ -195,11 +197,12 @@ box.space.features_memtx:create_index('functional_multikey',
>  actual = daemon.generate_feedback()
>  local schema_stats = actual.features.schema
>  test:test('features.schema', function(t)
> -    t:plan(12)
> -    t:is(schema_stats.memtx_spaces, 2, 'memtx engine usage gathered')
> +    t:plan(13)
> +    t:is(schema_stats.memtx_spaces, 3, 'memtx engine usage gathered')
>      t:is(schema_stats.vinyl_spaces, 1, 'vinyl engine usage gathered')
>      t:is(schema_stats.temporary_spaces, 1, 'temporary space usage gathered')
>      t:is(schema_stats.local_spaces, 1, 'local space usage gathered')
> +    t:is(schema_stats.sync_spaces, 1, 'sync space  usage gathered')

1. Double whitespace in 'space  usage'. At least the macbooks >= 2016
are stylish.

>      t:is(schema_stats.tree_indices, 6, 'tree index gathered')
>      t:is(schema_stats.hash_indices, 1, 'hash index gathered')
>      t:is(schema_stats.rtree_indices, 1, 'rtree index gathered')
2. I also see you pushed a new commit on top of this branch about reporting
box.on_reload_configuration. But why? It is not even documented anywhere.
We could just drop this function.