From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp35.i.mail.ru (smtp35.i.mail.ru [94.100.177.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 9864945C304 for ; Sun, 13 Dec 2020 21:56:40 +0300 (MSK) References: <38dc0666866f758690683c6e91a2ac2ed2f3306d.1606766417.git.sergeyb@tarantool.org> <20201207173429.GF5396@tarantool.org> From: Sergey Bronnikov Message-ID: <53b61df7-09f3-2cec-d144-724880b5101c@tarantool.org> Date: Sun, 13 Dec 2020 21:56:39 +0300 MIME-Version: 1.0 In-Reply-To: <20201207173429.GF5396@tarantool.org> Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: 8bit Content-Language: en-US Subject: Re: [Tarantool-patches] [PATCH 2/4] test: add corpus to be used with fuzzers List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Hello! thanks for review! On 07.12.2020 20:34, Igor Munkin wrote: > Sergey, > > Thanks for the patch! Please consider my comments below. > > On 30.11.20, sergeyb@tarantool.org wrote: >> From: Sergey Bronnikov >> >> Fuzzing tools uses evolutionary algorithms. Supplying seed corpus consisting >> of good sample inputs is one of the best ways to improve fuzz target’s >> coverage. Patch adds a corpuses that can be used with existed fuzzers. >> The name of each file in the corpus is the sha1 checksum of its contents. > Minor: The body of the commit message should be wrapped up to 72 > characters (except the links I believe) according to our guidelines[1]. Fixed in a branch. > >> Corpus with http headers was added from [1] and [2]. >> >> 1. https://google.github.io/oss-fuzz/getting-started/new-project-guide/#seed-corpus >> 2. https://en.wikipedia.org/wiki/List_of_HTTP_header_fields >> 3. https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers >> >> The libFuzzer allow to minimize corpus with help of `-merge` flag: >> when 1 is passed, any corpus inputs from the 2nd, 3rd etc. corpus directories >> that trigger new code coverage will be merged into the first corpus directory, >> when 0 is passed an existed corpus will be minimized. > Ditto. Fixed in a branch. >> All provided corpuses in a patch were minimized. >> >> Part of #1809 > I have no idea, how to review this patch further. It looks OK except the > testing fails the way I wrote in the previous reply. So, I stop here. > >> --- > > >> -- >> 2.25.1 >> > [1]: https://www.tarantool.io/en/doc/latest/dev_guide/developer_guidelines/ >