From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 85B9A469719 for ; Mon, 21 Sep 2020 23:15:12 +0300 (MSK) References: <20200920175930.9016-1-skaplun@tarantool.org> From: Vladislav Shpilevoy Message-ID: <539965bb-7c2b-6962-530f-d9494a71b260@tarantool.org> Date: Mon, 21 Sep 2020 22:15:10 +0200 MIME-Version: 1.0 In-Reply-To: <20200920175930.9016-1-skaplun@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH] cppcheck: box/alter.cc null pointer dereference List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sergey Kaplun , Mergen Imeev Cc: tarantool-patches@dev.tarantool.org Hi! Thanks for the patch! Commit title should be a subsystem name + description. Since we don't have 'cppcheck' subsystem, I propose to use 'alter'. LGTM except the commit title.