From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 052C225896
	for <tarantool-patches@freelists.org>; Tue, 29 Jan 2019 15:42:28 -0500 (EST)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id QWUJXA2pvwhh for <tarantool-patches@freelists.org>;
	Tue, 29 Jan 2019 15:42:27 -0500 (EST)
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id B5516255B1
	for <tarantool-patches@freelists.org>; Tue, 29 Jan 2019 15:42:27 -0500 (EST)
Subject: [tarantool-patches] Re: [PATCH v8 4/6] lua: create method dump_lua
 for port_sql
References: <cover.1547902954.git.imeevma@gmail.com>
 <c2e21045eb2d3ca7e61e3c91510ea80248471e25.1547902954.git.imeevma@gmail.com>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <534a3bdb-b245-ef71-69b5-4ec134f01c7c@tarantool.org>
Date: Tue, 29 Jan 2019 23:42:25 +0300
MIME-Version: 1.0
In-Reply-To: <c2e21045eb2d3ca7e61e3c91510ea80248471e25.1547902954.git.imeevma@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: imeevma@tarantool.org, tarantool-patches@freelists.org

Thanks for the patch! See 2 comments below.

> commit 78e3d54239d51ad52ebf377acb016c66426299ec
> Author: Mergen Imeev <imeevma@gmail.com>
> Date:   Fri Dec 21 16:48:37 2018 +0300
> 
>      lua: create method dump_lua for port_sql
>      
>      This patch creates the dump_lua method for port_sql. It also
>      defines a new function box.sql.new_execute(), which will be
>      converted to box.sql.execute().
>      
>      Part of ...3505
> 

1. Please, replace ... with # in all patches, as I asked in the
review of the first commit.

2. I think, that it is time to finally finish this patchset
and remove "new_execute" from this commit, and in the
last commit replace "sql.execute" with "execute".