From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 1CFEA6EC57; Fri, 15 Oct 2021 01:42:25 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1CFEA6EC57 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1634251345; bh=hZvgFsPZtHc9MDq4HqEzB1m9XI9/0CP4lWO0AIxS0VU=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=O1uVznJVh3XYkRaWH9PaR87LcJhaokqbKUP8zt6DNOOzmTl+y1liAvgJkxNAwERPu XLUnepQ1PnN2Y7meI5obE8indwL8Yq3SVTPlkXGnufOdGZb0+wVhTO8jiH6YanRQfR 9Z22zbZcXC5HUDxmX9lClIEii8wzwC8MVC3ZNhAg= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id BFC096EC57 for ; Fri, 15 Oct 2021 01:42:23 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BFC096EC57 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1mb9Qd-0004Ch-0z; Fri, 15 Oct 2021 01:42:23 +0300 Message-ID: <52e168e4-1559-fd6c-c5a6-d98e3c2d678a@tarantool.org> Date: Fri, 15 Oct 2021 00:42:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 To: imeevma@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: <7a6d7ca687a6e4d06b087af5f2e442042b38cf7b.1633713432.git.imeevma@gmail.com> Content-Language: en-US In-Reply-To: <7a6d7ca687a6e4d06b087af5f2e442042b38cf7b.1633713432.git.imeevma@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9AE9EF867AE584ADABE252565095BFC56DAA1DD28C916028A182A05F53808504079C31E0BA4831A7E96705C82C534958D93B4F1C842AAEE56602586E3A2140A02 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7544B1CCE26E01C74EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637651D61939D0B3DD78638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8AD2B085AF279318D5F890B5E6DD5D36C117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF1175FABE1C0F9B6A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD182CC0D3CB04F14752D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6300D3B61E77C8D3B089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B50580647984BABFFB520693F82305925509 X-C1DE0DAB: 0D63561A33F958A595A0B1B5F46396443CE774A1035809879CAB6B94FEE9EEEED59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA754A161BC97E2066CA410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34B7CBFF60649FF2660D5ACE7E1957B3347854D36244DF14B8ADFD2C5556FFF2A2B47B250D22F9ABBE1D7E09C32AA3244C64CF09A86E651219CC38E81817AC78498580396430872480729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojZCle+NCKLXHp1tuv50yrmA== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D7DD025F6D934396D2204EE8FFBB382813841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 01/21] sql: refactor CHAR() function X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the patch! Before this commit on the branch I see a comment called 'Fix'. Please, cleanup the branch from unfinished work. On 08.10.2021 19:31, imeevma@tarantool.org wrote: > Part of #4145 > --- > src/box/sql/func.c | 85 ++++++++++++++++++++++------------------------ > 1 file changed, 40 insertions(+), 45 deletions(-) > > diff --git a/src/box/sql/func.c b/src/box/sql/func.c > index a3c7d8d20..dd5e7d785 100644 > --- a/src/box/sql/func.c > +++ b/src/box/sql/func.c > @@ -738,6 +738,45 @@ func_substr_characters(struct sql_context *ctx, int argc, struct Mem *argv) > ctx->is_aborted = true; > } > > +/** Implementation of the CHAR() function. */ Please, keep the comments explaining what the non-trivial functions do. > +static void > +func_char(struct sql_context *ctx, int argc, struct Mem *argv) > +{