From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id C30476EC60; Tue, 30 Mar 2021 02:05:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C30476EC60 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617059149; bh=o+ncftrjg/yPXplaw7KiVq595wQwkobEaBU+JoSSPSg=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=joLh+bDY/41M7PCdxu2rvv7nnLOVj62JpVN2XrKHPNP6zJcffbC60Tc2CO7ZPZll9 OhScRUig5GjtXT4QQksF/UCM9wVGtohX33suaMt/X6TxmlxqxaLtQUZh2rW7tCSZxS 5DNnprxLgUP+QmT55leL2YQG6hBPIkVSfFFSszi8= Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 98C056EC60 for ; Tue, 30 Mar 2021 02:04:31 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 98C056EC60 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1lR0vu-0001JR-Sw; Tue, 30 Mar 2021 02:04:31 +0300 To: imeevma@tarantool.org, tsafin@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: <5878a78644e78681690c8404677fbd069776059c.1616491731.git.imeevma@gmail.com> Message-ID: <52d382f5-9219-2734-ed86-5c03a0e89305@tarantool.org> Date: Tue, 30 Mar 2021 01:04:30 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <5878a78644e78681690c8404677fbd069776059c.1616491731.git.imeevma@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947287414FD1D04A09E656A5F3377C994A182A05F538085040CB381C2286C6942A21738D632C33F8BCD1E95016829EA171FC3AF27E0C363C4A X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7EB05B7739F1E6D56EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637E31772672C957B658638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95CE99938B3FD79E1DF8395CEF479F1631F407E0F2245F3C787A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE77A825AB47F0FC8649FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C327ED053E960B195E117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947C0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735444A83B712AC0148C4224003CC83647689D4C264860C145E X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C97831B61D915BCC9FD1C960D789705920FE00 X-C1DE0DAB: 0D63561A33F958A5F5CA967F9162A4746C90B57E69A5A3DC6950C235509A2DACD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3433E9BC74ABA5769F548378F2456393C2D843C2B953E8EC28479BA767B5D34F56D7E4746D6F58B7C21D7E09C32AA3244C2E2B4FBFAFF3D3BFE39238B73D8C4980E8FBBEFAE1C4874CFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojljIiQOC84rQI6HI+Jf3AVw== X-Mailru-Sender: 689FA8AB762F73936BC43F508A06382283D7D17F895E446F21000F36114BD9DC3841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v4 25/53] sql: introduce mem_set_unsigned() X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the patch! > diff --git a/src/box/sql/mem.c b/src/box/sql/mem.c > index 13a587aba..f7a1a9b8a 100644 > --- a/src/box/sql/mem.c > +++ b/src/box/sql/mem.c > @@ -1765,7 +1774,7 @@ mem_convert_to_unsigned(struct Mem *mem) > double d = mem->u.r; > if (d < 0.0 || d >= (double)UINT64_MAX) > return -1; > - mem_set_u64(mem, (uint64_t) d); > + mem_set_unsigned(mem, (uint64_t) d); Whitespace after unary operator.