From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olegrok@tarantool.org>
Received: from smtp30.i.mail.ru (smtp30.i.mail.ru [94.100.177.90])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 6DA624696C1
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 24 Nov 2020 22:23:13 +0300 (MSK)
From: Oleg Babin <olegrok@tarantool.org>
References: <cover.1605685304.git.babinoleg@mail.ru>
 <696b028492d8c1e680a3386c87534d96eac7c272.1605685304.git.babinoleg@mail.ru>
 <20201124152054.GF14086@tarantool.org>
Message-ID: <52a36f3c-b886-044b-d0ba-e8cb30e37a31@tarantool.org>
Date: Tue, 24 Nov 2020 22:23:11 +0300
MIME-Version: 1.0
In-Reply-To: <20201124152054.GF14086@tarantool.org>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
Subject: Re: [Tarantool-patches] [PATCH v2 2/2] uuid: support uuid
 comparison with strings
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Igor Munkin <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org

Thanks for review!

On 24/11/2020 18:20, Igor Munkin wrote:
> Oleg,
>
> Thanks for the patch! Considering the version on the remote branch, LGTM
> except a single nit below.
>
> On 18.11.20,olegrok@tarantool.org  wrote:
>> From: Oleg Babin<babinoleg@mail.ru>
>>
>> Before this patch it was impossible to compare uuid values with
>> string representations of uuid. However we have cases when such
>> comparisons is possible (e.g. "decimal" where we can compare
>> decimal values with strings and numbers).
>>
>> This patch extends uuid comparators (eq, lt, le) and every string
> Minor: Strictly saying, you're right, but AFAICS we usually use the key
> name (i.e. __eq, __le and __lt) for metamethods in description.

I've updated and force-pushed branch. I cite only changed part:

     This patch extends uuid comparators (__eq, __lt and __le) and
     every string argument is tried to be converted to uuid value to
     compare then.