From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 1C3C06ECDB; Tue, 29 Sep 2026 13:31:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1C3C06ECDB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1790677900; bh=8MNANiTfHnNnKkJT3GUSg4nHT0luk9SliSSNZsFnby8=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=M3QFdYz2Zw1cOpZg7NdHDMcfJx0hP1rwuUcRlUjDZ+SaxRaCbkcOOZ1alzOSPrmoR wPyqxHerLDWTNglANzv1gBQaZ3GEp1WcElDZvnjZJrFGyp/t+WR+hwhZc1ATk/QTaJ NCvgMkioCzZrMCNv3KpX5DyYqdK6PB3eJiPX6eVI= Received: from send36.i.mail.ru (send36.i.mail.ru [89.221.237.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 5DADB6ECDB for ; Tue, 29 Sep 2026 13:31:38 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5DADB6ECDB Received: by exim-smtp-65f8d7bcb-5d6zt with esmtpa (envelope-from ) id 1xBV7Z-00000000QBV-0nyB; Tue, 29 Sep 2026 13:31:37 +0300 Message-ID: <528c3aa4-cd63-47d1-9959-6e9ff794adfb@tarantool.org> Date: Tue, 29 Sep 2026 13:31:36 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Sergey Bronnikov References: <20260928064218.96994-1-e.temirgaleev@tarantool.org> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD94B2D473D652AD5AC459A1FE8A7DDEA4ACCEDFB98C250F4CC182A05F538085040E53A74C158A93D0E3DE06ABAFEAF67056071BFFF385E14008BB20D4CEC4DC45ACF784B0C616BB7A4 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE71EEA4C46C73542F4EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB5533756689D67F2C7FEA51B53843413B145F23C77B07B3F734D54B79C0C774C10D3B2070389733CBF5DBD5E9D5E8D9A59859A8B636DA1BED736F9328CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8090A508E0FED6299176DF2183F8FC7C0207D9C0C136568F0CD04E86FAF290E2DB606B96278B59C421DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B615F38A1EB2280F99089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A585C2A0E08A7D26875002B1117B3ED6963A29C4C74574734E406406D89DD9EB8A823CB91A9FED034534781492E4B8EEADB05233B9BC4759D3 X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D6597627D6AC07E92E05CC433017696B4483C8D452CC0E62338E0542E7ABB6F5CEEDBBC70AECB8CC93ADB8341EE9D5BE9A0A020BBD7BAFBC5F25496FCC2F58A5F65DFA4C711785E5A9496536EB022892E5344C41F94D744909CEEF9E35A692215F79327F81E6EEE0AEB67A0F9F91F029B6AF33F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXOcIETfglQORZ0zpDET4Zrk3igikrdHlWCjmzNveKoDknNR0l9D9uPM= X-Mailru-Sender: 9482C2B233321BD2866703C3B73F8055DEAA29D8E62D4B9256704ABB56AC4A0F3EEAF62FDB1C67159C25F03E2EE9BBC98C34D365DA2E1307B60569B44082A3A3197AF8DA6C69D34BA7BD66BEAC8CCB0C4198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] test: disabled flaky test for OSX/ARM64 X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Evgeniy Temirgaleev via Tarantool-patches Reply-To: Evgeniy Temirgaleev Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for review. Please, see my answers below. The branch is force pushed with new commit message. 28.09.2026 15:45, Sergey Bronnikov пишет: > Hello, Evgeniy! > > Thanks for the patch! LGTM with minor comments below. > > Sergey > > On 9/28/26 09:42, Evgeniy Temirgaleev wrote: >> From: Temir Galeev >> >> The test `fix-mips64-spare-side-exit-patching.test.lua` >> is flaky on OSX and ARM64. >> >> The problem is in the limited range for mcode chunk's >> addresses on ARM64 and in the OSX strategy for `mmap` >> to ignore user's hint [1]. > The commit message should contain a trailer "Closes tarantool/ > tarantool#13261", right? None. The ticket is more general. It's about mcode allocation problem due to address range limitation. Updated the commit description. >> >> 1. https://github.com/tarantool/tarantool/issues/13261 >> >> Branch: https://github.com/tarantool/luajit/tree/tmr_g/gh-13621-flaky- >> fix-mips64-se >> >> --- >>   .../fix-mips64-spare-side-exit-patching.test.lua                | 2 ++ >>   1 file changed, 2 insertions(+) >> >> diff --git a/test/tarantool-tests/fix-mips64-spare-side-exit- >> patching.test.lua b/test/tarantool-tests/fix-mips64-spare-side-exit- >> patching.test.lua >> index dd9f2073..0a9e230f 100644 >> --- a/test/tarantool-tests/fix-mips64-spare-side-exit-patching.test.lua >> +++ b/test/tarantool-tests/fix-mips64-spare-side-exit-patching.test.lua >> @@ -4,6 +4,8 @@ local test = tap.test('fix-mips64-spare-side-exit- >> patching'):skipcond({ >>     ['Disabled on *BSD due to #4819'] = jit.os == 'BSD', >>     -- We need to fix the MIPS behaviour first. >>     ['Disabled for MIPS architectures'] = jit.arch:match('mips'), >> +  ['Disabled on *OSX/ARM64 due to #13261'] = jit.os == 'OSX' and > > s/*OSX/macOS/ Fixed, thanks! > > Feel free to ignore. > > OS X is the old official name (used from 2012 to 2016). It is best > avoided now, > > except when referring to specific historical versions (e.g., OS X El > Capitan). > > macOS is the current official name. It is generally not abbreviated > further. > > osx / OSX is an unofficial, colloquial abbreviation. It appears in tags, > filenames, > > and casual conversation. While technically incorrect, it is widely > recognized. > > >> +                                             jit.arch:match('arm64'), >>   }) >>   local generators = require('utils').jit.generators -- Updated commit message: test: disabled flaky test for macOS/ARM64 The test `fix-mips64-spare-side-exit-patching.test.lua` is flaky on macOS and ARM64. The problem is in the limited range for mcode chunk's addresses on ARM64 and in the macOS strategy for `mmap` to ignore user's hint. See [1] for details. After the solution for the address range limitation problem will be applied, the test must be reenabled. 1. https://github.com/tarantool/tarantool/issues/13261 Part of #13261 -- Best regards, Evgeniy Temirgaleev