From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id C019B294E0 for ; Thu, 16 Aug 2018 09:45:14 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0RQQLQpLVmb8 for ; Thu, 16 Aug 2018 09:45:14 -0400 (EDT) Received: from smtp62.i.mail.ru (smtp62.i.mail.ru [217.69.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 7C2E4294DE for ; Thu, 16 Aug 2018 09:45:14 -0400 (EDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: triggers on view unfinished updates From: "n.pettik" In-Reply-To: Date: Thu, 16 Aug 2018 16:45:09 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <523E8244-AC85-4EE1-B08F-047EC74FAFA7@tarantool.org> References: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: Kirill Shcherbatov > Excepting primary index is a typical thing for view so Nitpicking: not =E2=80=98excepting=E2=80=99 but lack of I guess. > we should use space_index instead of index_find that doesn't > setup diag error when no index is finded. >=20 > Closes #3536. > --- > diff --git a/test/sql/triggers.test.lua b/test/sql/triggers.test.lua > index 8fd385c..fff58e9 100644 > --- a/test/sql/triggers.test.lua > +++ b/test/sql/triggers.test.lua > @@ -142,3 +142,17 @@ box.sql.execute("SELECT * FROM test2") > box.sql.execute("ROLLBACK;") > box.sql.execute("DROP TABLE test;") > box.sql.execute("DROP TABLE test2;") > + > +-- > +-- gh-3536: Some triggers cause error messages and/or half-finished = updates > +-- > +box.cfg{} Why do you need to call box.cfg{} here?=