From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id C9FDCC99148; Thu, 15 Aug 2024 16:11:54 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C9FDCC99148 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1723727514; bh=BYkLmK3T0pgTioAWRu84XLf8MyZeg3XBH7HV7MtSdxo=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=gpbr3rQ5BnrJhqomMWZVB73fsM3H1KcC7aslG/6LceOL/2RddFHBJ53qFmXdr/1l+ 6NXgJhVyWLLu+1QruL7txVcPT5piAPQquRleU6QgFeM3LdPZJpxsk+0wuS7o71Myeu 5fQEjQzaFBHtyUH5QHfnsNuW5xlC/khHcmOLi1s0= Received: from smtp51.i.mail.ru (smtp51.i.mail.ru [95.163.41.87]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id BA6CCC99149 for ; Thu, 15 Aug 2024 16:11:53 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BA6CCC99149 Received: by smtp51.i.mail.ru with esmtpa (envelope-from ) id 1seaGd-0000000BLq7-0BGu; Thu, 15 Aug 2024 16:11:51 +0300 Content-Type: multipart/alternative; boundary="------------My0gLJ1pkJAYZfg0mAnClFg2" Message-ID: <52343605-6c27-4f5e-8cef-7a350d378261@tarantool.org> Date: Thu, 15 Aug 2024 16:11:50 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun , Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org References: <0b86cd86732162470eea910ae9cdea48219e53bd.1723638851.git.skaplun@tarantool.org> In-Reply-To: <0b86cd86732162470eea910ae9cdea48219e53bd.1723638851.git.skaplun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9F97E3C14763C38E21D034174EA8ECC476D3C65BCD9935719182A05F53808504028A9969BFE8A94AE33594132A326AF8BC1BFA28854BBA0F10D0D019245ED27CD495FBEDC84B91D45 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE74FF5DF51D335CFFFEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006370CE4B4B08BC34B6C8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8651649B15AE593C87DD778E7BCC24094FA95BF084FB51681CC7F00164DA146DAFE8445B8C89999728AA50765F7900637F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F7900637F924B32C592EA89F389733CBF5DBD5E9B5C8C57E37DE458BD9DD9810294C998ED8FC6C240DEA76428AA50765F790063790495A4AD0498982D81D268191BDAD3DBD4B6F7A4D31EC0BE2F48590F00D11D6D81D268191BDAD3D78DA827A17800CE72B056A9979167638EC76A7562686271ED91E3A1F190DE8FD2E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3A27B50A64E76B53235872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5367B89923E230A765002B1117B3ED696E7ECB24F60185A1DC81EEE05487B0209823CB91A9FED034534781492E4B8EEAD09F854029C6BD0DABDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF1982C9DFCE6FCD759436E99D6E3BA01F857FB19271CDDB2585514896F367EAEC9F3638D7DAB8774B470327EB0AC8E69369D48B4635BC53E30DC3F8217F85065E10ED67D8D125D1B65F4332CA8FE04980913E6812662D5F2AB9AF64DB4688768036DF5FE9C0001AF333F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojD5rM0r3KxnFevftoYyPQtA== X-Mailru-Sender: 520A125C2F17F0B1E52FEF5D219D6140825A444343278A5F392A493927CAD3414B9E2048E4FD4F660152A3D17938EB451EB5A0BCEC6A560B3DDE9B364B0DF289BE2DA36745F2EEB5CEBA01FB949A1F1EEAB4BC95F72C04283CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 06/36] test: enable LuaJIT test X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------My0gLJ1pkJAYZfg0mAnClFg2 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Sergey thanks for the patch! see my comments below On 14.08.2024 16:55, Sergey Kaplun wrote: > This patch moves the aforementioned test from the to the > directory, includes it in , and names subtests. Add a reason for this and couple of words about updated formatting in the test. > Part of tarantool/tarantool#9398 > --- > test/LuaJIT-tests/{misc => lang}/dualnum.lua | 24 +++++++++----------- > test/LuaJIT-tests/lang/index | 1 + > 2 files changed, 12 insertions(+), 13 deletions(-) > rename test/LuaJIT-tests/{misc => lang}/dualnum.lua (57%) > > diff --git a/test/LuaJIT-tests/misc/dualnum.lua b/test/LuaJIT-tests/lang/dualnum.lua > similarity index 57% > rename from test/LuaJIT-tests/misc/dualnum.lua > rename to test/LuaJIT-tests/lang/dualnum.lua > index 5f1288c8..688920eb 100644 > --- a/test/LuaJIT-tests/misc/dualnum.lua > +++ b/test/LuaJIT-tests/lang/dualnum.lua > @@ -1,34 +1,32 @@ > +-- Test LuaJIT Dualnum mode behaviour. > > --- Positive overflow > -do > +do --- Positive overflow. > local x = 0 > - for i=2147483446,2147483647,2 do x = x + 1 end > + for _ = 2147483446, 2147483647, 2 do x = x + 1 end > assert(x == 101) > end > > --- Negative overflow > -do > +do --- Negative overflow. > local x = 0 > - for i=-2147483447,-2147483648,-2 do x = x + 1 end > + for _ = -2147483447, -2147483648, -2 do x = x + 1 end > assert(x == 101) > end > > --- SLOAD with number to integer conversion. > -do > +do --- SLOAD with number to integer conversion. > local k = 1 > local a, b, c = 1/k, 20/k, 1/k > - for i=1,20 do > - for j=a,b,c do end > + for i = 1, 20 do > + for j = a, b, c do end > end > end > > -do > +do --- min/max correctness. > local function fmin(a, b) > - for i=1,100 do a = math.min(a, b) end > + for _ = 1, 100 do a = math.min(a, b) end > return a > end > local function fmax(a, b) > - for i=1,100 do a = math.max(a, b) end > + for _ = 1, 100 do a = math.max(a, b) end > return a > end > assert(fmin(1, 3) == 1) > diff --git a/test/LuaJIT-tests/lang/index b/test/LuaJIT-tests/lang/index > index 4d9feafd..b0e7f073 100644 > --- a/test/LuaJIT-tests/lang/index > +++ b/test/LuaJIT-tests/lang/index > @@ -6,6 +6,7 @@ catch_wrap.lua > compare.lua > compare_nan.lua > constant > +dualnum.lua > for.lua > length.lua > lightud.lua --------------My0gLJ1pkJAYZfg0mAnClFg2 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi, Sergey

thanks for the patch!

see my comments below

On 14.08.2024 16:55, Sergey Kaplun wrote:
This patch moves the aforementioned test from the <misc> to the <lang/>
directory, includes it in <index>, and names subtests.

Add a reason for this and couple of words about updated formatting in the test.


Part of tarantool/tarantool#9398
---
 test/LuaJIT-tests/{misc => lang}/dualnum.lua | 24 +++++++++-----------
 test/LuaJIT-tests/lang/index                 |  1 +
 2 files changed, 12 insertions(+), 13 deletions(-)
 rename test/LuaJIT-tests/{misc => lang}/dualnum.lua (57%)

diff --git a/test/LuaJIT-tests/misc/dualnum.lua b/test/LuaJIT-tests/lang/dualnum.lua
similarity index 57%
rename from test/LuaJIT-tests/misc/dualnum.lua
rename to test/LuaJIT-tests/lang/dualnum.lua
index 5f1288c8..688920eb 100644
--- a/test/LuaJIT-tests/misc/dualnum.lua
+++ b/test/LuaJIT-tests/lang/dualnum.lua
@@ -1,34 +1,32 @@
+-- Test LuaJIT Dualnum mode behaviour.
 
--- Positive overflow
-do
+do --- Positive overflow.
   local x = 0
-  for i=2147483446,2147483647,2 do x = x + 1 end
+  for _ = 2147483446, 2147483647, 2 do x = x + 1 end
   assert(x == 101)
 end
 
--- Negative overflow
-do
+do --- Negative overflow.
   local x = 0
-  for i=-2147483447,-2147483648,-2 do x = x + 1 end
+  for _ = -2147483447, -2147483648, -2 do x = x + 1 end
   assert(x == 101)
 end
 
--- SLOAD with number to integer conversion.
-do
+do --- SLOAD with number to integer conversion.
   local k = 1
   local a, b, c = 1/k, 20/k, 1/k
-  for i=1,20 do
-    for j=a,b,c do end
+  for i = 1, 20 do
+    for j = a, b, c do end
   end
 end
 
-do
+do --- min/max correctness.
   local function fmin(a, b)
-    for i=1,100 do a = math.min(a, b) end
+    for _ = 1, 100 do a = math.min(a, b) end
     return a
   end
   local function fmax(a, b)
-    for i=1,100 do a = math.max(a, b) end
+    for _ = 1, 100 do a = math.max(a, b) end
     return a
   end
   assert(fmin(1, 3) == 1)
diff --git a/test/LuaJIT-tests/lang/index b/test/LuaJIT-tests/lang/index
index 4d9feafd..b0e7f073 100644
--- a/test/LuaJIT-tests/lang/index
+++ b/test/LuaJIT-tests/lang/index
@@ -6,6 +6,7 @@ catch_wrap.lua
 compare.lua
 compare_nan.lua
 constant
+dualnum.lua
 for.lua
 length.lua
 lightud.lua
--------------My0gLJ1pkJAYZfg0mAnClFg2--