From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 3D3FC2DD0E
	for <tarantool-patches@freelists.org>; Mon, 19 Nov 2018 12:27:42 -0500 (EST)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id UqH-KgUIHuhC for <tarantool-patches@freelists.org>;
	Mon, 19 Nov 2018 12:27:42 -0500 (EST)
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id D46DB2D6F6
	for <tarantool-patches@freelists.org>; Mon, 19 Nov 2018 12:27:41 -0500 (EST)
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.0 \(3445.100.39\))
Subject: [tarantool-patches] Re: [PATCH 2/3] sql: SELECT from system spaces
 returns unpacked msgpack.
From: "n.pettik" <korablev@tarantool.org>
In-Reply-To: <9e22a12510a952d2378d8b926db266f4a426c332.1542635129.git.v.shpilevoy@tarantool.org>
Date: Mon, 19 Nov 2018 20:27:39 +0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <5233E694-9416-4094-8E73-1F46B3205C91@tarantool.org>
References: <cover.1542635129.git.v.shpilevoy@tarantool.org>
 <cover.1542635129.git.v.shpilevoy@tarantool.org>
 <9e22a12510a952d2378d8b926db266f4a426c332.1542635129.git.v.shpilevoy@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: Imeev Mergen <imeevma@tarantool.org>, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>

Please, don=E2=80=99t state problem in commit message. Instead, it would =
be
better to indicate fix of the problem. I would call it like:

sql: decode mgspack after SELECT from system spaces

Otherwise it looks like you are introducing new bug :)

Also, your patch affects not only system spaces.
For example:

box.schema.space.create('t=E2=80=99)
box.space.t:format({{name =3D 'id', type =3D 'integer'}, {name =3D 'x', =
type =3D 'any'}})
box.space.t:create_index('i1', {parts =3D {1, 'int'}})
box.space.t:insert({1, {1,2,3}})
box.space.t:insert({2, {a =3D 3}})

Before your patch:

tarantool> cn:execute('select * from \"t\"')
---
- metadata:
  - name: id
    type: UNKNOWN
  - name: x
    type: UNKNOWN
  rows:
  - [1, !!binary kwECAw=3D=3D]
  - [2, !!binary gaFhAw=3D=3D]
...

After:

tarantool> cn:execute('select * from \"t\"')
---
- metadata:
  - name: id
    type: UNKNOWN
  - name: x
    type: UNKNOWN
  rows:
  - [1, [1, 2, 3]]
  - [2, {'a': 3}]
=E2=80=A6

I guess more precise to say sort of:

sql: decode ARRAY and MAP types after SELECT

Patch itself is OK, but I would rework test in order to avoid
using system spaces. It is up to you.