From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 676066B963; Tue, 13 Apr 2021 16:39:36 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 676066B963 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1618321176; bh=bs4nUtUq2tQhZDnCA+bXTozyqO9FNkUqPwGwXVFAde0=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=D5HZA3VCVROauJqyG5Eoi45z0s63+ARaRH4/Mc+2J0gQGW2lzUSeDv/83a9VER9hV frQVX0U8cQwqeqZa2ZdXANb3kqS9KMDngBqKoqA2+0J8yrIJLdryy+a2y+PeIadiKS yrDGA2w7D6omB7ZG27Gv7omWyXhPJB8ad2dHoc6E= Received: from smtp48.i.mail.ru (smtp48.i.mail.ru [94.100.177.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 380546B967 for ; Tue, 13 Apr 2021 16:29:04 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 380546B967 Received: by smtp48.i.mail.ru with esmtpa (envelope-from ) id 1lWJ6F-0000dj-R7; Tue, 13 Apr 2021 16:29:04 +0300 To: Sergey Ostanevich , Igor Munkin Date: Tue, 13 Apr 2021 16:27:22 +0300 Message-Id: <521301d79ff90b6dd9b7a5bc345f84a31540c1a3.1618320000.git.skaplun@tarantool.org> X-Mailer: git-send-email 2.31.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD92FFCB8E6708E748094FADAEB10E66ADA4C48BE3C291E66DA182A05F538085040CD08E7D2845C80C2FB61DFCA7969C0D8F39B59C100D51B9B69569462D4E602FD X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F2393C4755A27B53EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006378F586D843116CFB2EA1F7E6F0F101C67CDEEF6D7F21E0D1D9295C2E9FA3191EE1B59CA4C82EFA65886F84DCEDB4FBFB1100EE7171D641022F6B57BC7E64490618DEB871D839B73339E8FC8737B5C224901F8F2FECC0250C8CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C0EF2A066DDA19BA868941B15DA834481F9449624AB7ADAF372E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89F4AF35CDC743633045E1C53F199C2BB95B5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: C20DE7B7AB408E4181F030C43753B8186998911F362727C4C7A0BC55FA0FE5FC7F657775A4D6396852E44E61696F9E621C38AD5912DAA91AB1881A6453793CE9C32612AADDFBE061C61BE10805914D3804EBA3D8E7E5B87ABF8C51168CD8EBDB63AF70AF8205D7DCDC48ACC2A39D04F89CDFB48F4795C241BDAD6C7F3747799A X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D343D50AEDB859DBAD9C3F74ECBDAE436BA1E5164B3EDE300D9231B01A7A541413D4AB5EF1209E6E7641D7E09C32AA3244C1401FD67E1F7734FD63F5DAA4F3AA547F94338140B71B8EE927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojnA7/qPBUIXF/6PgjsSySfw== X-Mailru-Sender: 3B9A0136629DC91206CBC582EFEF4CB4DA0825BFC358DA630CB0C4669B49AB2C4EAB46A6D34EF626F2400F607609286E924004A7DEC283833C7120B22964430C52B393F8C72A41A89437F6177E88F7363CDA0F3B3F5B9367 X-Mras: Ok Subject: [Tarantool-patches] [PATCH luajit v3 22/29] test: disable PUC-Rio test for fast function name X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" When LuaJIT tries to detect function's name for error message, it determines the bytecode position first, via `debug_framepc()`. For tailcall there is no creation of additional Lua frame, so the current frame is a C protected frame (at the moment of the error throwing). `debug_framepc()` can't determine bytecode position for non-Lua frames, so the fast function name is not detected. This patch disables the test that checks the name of built-in functions reported in error in tail call. Part of tarantool/tarantool#5845 Part of tarantool/tarantool#4473 --- test/PUC-Rio-Lua-5.1-tests/errors.lua | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/test/PUC-Rio-Lua-5.1-tests/errors.lua b/test/PUC-Rio-Lua-5.1-tests/errors.lua index c9d79279..1cc01564 100644 --- a/test/PUC-Rio-Lua-5.1-tests/errors.lua +++ b/test/PUC-Rio-Lua-5.1-tests/errors.lua @@ -105,9 +105,17 @@ while 1 do insert(prefix, a) end]], "global 'insert'") -checkmessage([[ -- tail call - return math.sin("a") -]], "'sin'") +-- LuaJIT: When LuaJIT tries to detect function's name for error +-- message, it determines the bytecode position first, via +-- `debug_framepc()`. For tailcall there is no creation of +-- additional Lua frame, so the current frame is a C protected +-- frame (at the moment of the error throwing). `debug_framepc()` +-- can't determine bytecode position for non-Lua frames, so +-- the fast function name is not detected. +-- The test is disabled for LuaJIT. +-- checkmessage([[ -- tail call +-- return math.sin("a") +-- ]], "'sin'") checkmessage([[collectgarbage("nooption")]], "invalid option") -- 2.31.0