From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id E4CEE21C97 for ; Tue, 26 Jun 2018 12:13:47 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jxAA58R5jj89 for ; Tue, 26 Jun 2018 12:13:47 -0400 (EDT) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 9D6B421CAA for ; Tue, 26 Jun 2018 12:13:47 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v4 5/6] sql: move Triggers to server References: <8d28de228babb13b962c8ffed9399caf45586447.1529490955.git.kshcherbatov@tarantool.org> <4FD641D5-2133-4135-ADC6-72900826F458@tarantool.org> <5704ba48-ea6b-4995-c405-4ea7c1ade87c@tarantool.org> From: Kirill Shcherbatov Message-ID: <515555d9-bc96-10b8-dbbe-10502e1f9cdf@tarantool.org> Date: Tue, 26 Jun 2018 19:13:45 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: "n.pettik@corp.mail.ru" > Now it is possible to delete trigger using only its name, since > in on_replace_dd_trigger() we would have space_id from tuple. > So, we came to agreement to delete global hash of triggers. I'll send a patch. > It would be great if you provided diff: right here, at the end of letter or > as a next patch version. Don’t forget next time. Ok, I'll try do not forget next time. > Please, sent that patch or attach diff. I'll send a patch. > Add cautionary (or FIXME) comment which would explain that > in case of RENAME’s fail we are totally fucked up: part of triggers > remain with old space’s name. Thus, after creation of new space with > the name of old one, it appears with triggers which haven’t been created. + /* + * FIXME: In the case of error, + * part of triggers would have invalid + * space name in tuple so can not been + * persisted. + * Server could be restarted. + * In this case, rename table back and + * try again. + */