From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 95CAF262FA for ; Tue, 10 Jul 2018 11:56:26 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id U7SKJO7MFtYw for ; Tue, 10 Jul 2018 11:56:26 -0400 (EDT) Received: from smtp29.i.mail.ru (smtp29.i.mail.ru [94.100.177.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 51634262F5 for ; Tue, 10 Jul 2018 11:56:26 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: refactor vdbe_emit_open_cursor calls References: <94a3289e26898b8f779450bf620d8fef454844c7.1531140049.git.kshcherbatov@tarantool.org> <96598d88-35f2-3075-6f90-f2efecd2f0cd@tarantool.org> <665e7af1-3a3c-ed51-e9e8-097811a4a7a6@tarantool.org> <15e20c40-fc3d-0b1d-271c-5dfaa76d6dd7@tarantool.org> From: Vladislav Shpilevoy Message-ID: <512e60bd-1886-56c3-2d30-e8171e1c0fa1@tarantool.org> Date: Tue, 10 Jul 2018 18:56:24 +0300 MIME-Version: 1.0 In-Reply-To: <15e20c40-fc3d-0b1d-271c-5dfaa76d6dd7@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Kirill Shcherbatov , tarantool-patches@freelists.org >> 2. Why vdbe_emit_open_cursor opens the cursor using index_id, >> but opcode OP_OpenRead/Write still uses it as tnum? > It is much more convenient to do this as a part of next commit. > I temporary put this changes as a commit at head > "sql: uniform OP_Open{Write,Read} ops to use tnum" Maybe it is more convenient, but it is not more correct. Your first commit still does not fix the mess with index_id/tnum. Please, squash it into your first commit.