From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kshcherbatov@tarantool.org>
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 506E141D0BD
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 16 Oct 2019 15:53:08 +0300 (MSK)
References: <cover.1571068485.git.kshcherbatov@tarantool.org>
 <20191015213405.GB898@tarantool.org> <20191016055725.GB16587@atlas>
 <20191016110739.GB11847@tarantool.org> <20191016111142.GA16144@atlas>
 <20191016121811.GA12432@tarantool.org>
From: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Message-ID: <50e10b12-31a5-cfc0-d4ac-76d66512db43@tarantool.org>
Date: Wed, 16 Oct 2019 15:53:07 +0300
MIME-Version: 1.0
In-Reply-To: <20191016121811.GA12432@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [tarantool-patches] Re: [PATCH v1 0/9]
 schema: rework _trigger space
List-Id: Tarantool development <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: tarantool-patches@freelists.org, Nikita Pettik <korablev@tarantool.org>, Konstantin Osipov <kostja.osipov@gmail.com>, tarantool-patches@dev.tarantool.org

> - name (both have)
> - func_id (only Lua)
> - space_id (both have)
> - type (means one of replace/connection/auth etc; only Lua)
> - event (only SQL)
> - action_time (SQL and Lua have sets of timings which don't intersect)
> - action (only SQL)

I need to mention that I didn't followed this outdated proposal in the
refactoring that we are discussing.

<name> STRING  (both have)
<space_id> UINT32 (both have)
<opts> MAP (non of them for now, legacy, but potentially usefull)
<language> STR (both have)
<type> STR (both have; currently 'replace' type only - replace trigger;
                      perhaps we would like to support some different trigger types)
<event_manipulation> STR  {"DELETE", "UPDATE", "INSERT" --
                                               SQL only? - but it is possible to support it in Lua also}
<action_timing> STR {"BEFORE", "AFTER" - both have}
<code> STR (both have)