From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp50.i.mail.ru (smtp50.i.mail.ru [94.100.177.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 72318469710 for ; Thu, 28 May 2020 13:42:02 +0300 (MSK) References: <20200528100738.221911-1-gorcunov@gmail.com> <20200528100738.221911-2-gorcunov@gmail.com> From: lvasiliev Message-ID: <50a32f08-7cb0-bfe0-c63f-da91d6e7331b@tarantool.org> Date: Thu, 28 May 2020 13:42:01 +0300 MIME-Version: 1.0 In-Reply-To: <20200528100738.221911-2-gorcunov@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH v4 1/8] core/say: do not reconfig early set up logger List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cyrill Gorcunov , tml Hi! Thank you for the patch. I have a minor comment that can be skipped silently. > diff --git a/src/lib/core/say.h b/src/lib/core/say.h > index c50d7bbf4..857145465 100644 > --- a/src/lib/core/say.h > +++ b/src/lib/core/say.h > @@ -274,6 +274,10 @@ say_logger_init(const char *init_str, > const char *log_format, > int background); > > +/** Test if logger is initialized. */ > +bool > +say_logger_initialized(void); > + I think this function may be used for the check in say_logger_free() instead log_default == &log_std. > /** Free default logger */ > void > say_logger_free(); >