From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp62.i.mail.ru (smtp62.i.mail.ru [217.69.128.42])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 00F69469719
 for <tarantool-patches@dev.tarantool.org>;
 Tue,  3 Mar 2020 00:06:50 +0300 (MSK)
References: <b6cf85b5ac4fa1d4e76ceaa89c9e74517e75137e.1582674708.git.v.shpilevoy@tarantool.org>
 <08e87903-c00a-9f8a-ff25-5199eb6be0f8@tarantool.org>
 <98c0554d-be84-578c-f8e9-d64b23d63623@tarantool.org>
 <ddd8aa66-b376-034c-fa0b-d4db26e6be61@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <5033adad-c28d-02e3-6de7-8e22a35c7f5c@tarantool.org>
Date: Mon, 2 Mar 2020 22:06:49 +0100
MIME-Version: 1.0
In-Reply-To: <ddd8aa66-b376-034c-fa0b-d4db26e6be61@tarantool.org>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [Tarantool-patches] [PATCH vshard 1/1] router:
 bucket_id_strcrc32 and bucket_id_mpcrc32
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Oleg Babin <olegrok@tarantool.org>, tarantool-patches@dev.tarantool.org

Thanks for the review!

On 02/03/2020 09:10, Oleg Babin wrote:
> Hi! Your tests fail on Tarantool 1.10:
> 
> [001] Test failed! Result content mismatch:
> [001] --- unit/router.result    Mon Mar  2 10:54:48 2020
> [001] +++ unit/router.reject    Mon Mar  2 11:02:21 2020
> [001] @@ -75,7 +75,7 @@
> [001]   |   - - string
> [001]   |     - '1'
> [001]   |     - 477
> [001] - |   - - ctype<struct 106>
> [001] + |   - - number
> [001]   |     - 1
> [001]   |     - 477
> [001]   | ...
> 
> 
> Without taking this into account - patch LGTM.

I fixed that and pushed to master.