From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id CF81F46970E for ; Wed, 18 Dec 2019 11:52:59 +0300 (MSK) From: Leonid Vasiliev Date: Wed, 18 Dec 2019 11:52:56 +0300 Message-Id: <4fdff09679c5a82c5f845343895b9d54be39b653.1576658855.git.lvasiliev@tarantool.org> Subject: [Tarantool-patches] [PATCH] Release all taken tasks on start List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: alexander.turenko@tarantool.org Cc: tarantool-patches@dev.tarantool.org https://github.com/tarantool/queue/issues/66 https://github.com/tarantool/queue/tree/lvasiliev/gh-66-release-taken-tasks-after-reboot If some tasks have been taken and don't released before shutdown of the tarantool instance (for example: tarantool instance has been killed) such task go to 'hung' state (noone can take the task now). So, we must release all taken tasks on start of the queue module. --- queue/abstract.lua | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/queue/abstract.lua b/queue/abstract.lua index ad8817d..ed07d85 100644 --- a/queue/abstract.lua +++ b/queue/abstract.lua @@ -511,7 +511,18 @@ function method.start() }) end - _queue:pairs():each(recreate_tube) + for _, tube_tuple in _queue:pairs() do + local space_name = tube_tuple[3] + tube = recreate_tube(tube_tuple) + local space = box.space[space_name] + for _, task_tuple in space:pairs() do + -- Release all taken tasks + local tid, task_state = task_tuple:unpack() + if task_state == state.TAKEN then + tube.raw:release(tid, {}) + end + end + end session.on_disconnect(queue._on_consumer_disconnect) return queue -- 2.17.1