From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 506E324C64 for ; Fri, 25 May 2018 07:54:10 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 17mVwCm0NzmJ for ; Fri, 25 May 2018 07:54:10 -0400 (EDT) Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 0BA8924C57 for ; Fri, 25 May 2018 07:54:10 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v7 3/7] sql: introduce expr_len for sql_expr_compile References: <074eb3156b959d1a5cc8534ec104b0bb6fc20034.1527084287.git.kshcherbatov@tarantool.org> <14b9b088-c650-e233-167a-24e9f35dfa8c@tarantool.org> From: Kirill Shcherbatov Message-ID: <4e5b5f63-509e-70ee-6da6-6fb1d49ee800@tarantool.org> Date: Fri, 25 May 2018 14:54:07 +0300 MIME-Version: 1.0 In-Reply-To: <14b9b088-c650-e233-167a-24e9f35dfa8c@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: "v.shpilevoy@tarantool.org" > 1. Looks like expr_len is the expression that is intended to > parse a length. > Do you mean this?: "Length of @an expr." - * @param expr_len Expression to parse length. + * @param expr_len Length of @an expr.. > 2. Bad indentation. int sql_expr_compile(struct sqlite3 *db, const char *expr, int expr_len, - struct Expr **result); + struct Expr **result);