From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>, avtikhon@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH] feedback_daemon: fix indexing a nil value issue
Date: Tue, 20 Apr 2021 00:39:20 +0200 [thread overview]
Message-ID: <4e0dd508-1747-1264-95e2-2a32e4b2208c@tarantool.org> (raw)
In-Reply-To: <20210419175357.13479-1-sergepetrenko@tarantool.org>
Thanks for the patch!
For bugfixes we usually add a test. Looks fine except that.
But I didn't validate (because no a test).
next prev parent reply other threads:[~2021-04-19 22:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 17:53 Serge Petrenko via Tarantool-patches
2021-04-19 22:39 ` Vladislav Shpilevoy via Tarantool-patches [this message]
2021-04-20 9:28 ` Serge Petrenko via Tarantool-patches
2021-04-20 19:42 ` Vladislav Shpilevoy via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e0dd508-1747-1264-95e2-2a32e4b2208c@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=avtikhon@tarantool.org \
--cc=sergepetrenko@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] feedback_daemon: fix indexing a nil value issue' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox