From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 63BDD6EC55; Wed, 8 Sep 2021 01:00:01 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 63BDD6EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1631052001; bh=fj2VbYusArAxb6iDcuwiJtDQmVWPn15+Y8WLLFl25JQ=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=HDr9L7wFsbjyDIDbS0KvEEba9mr4gZR+H3Sdg/6bD12OQfBNZG9L1LTHSQPsuVAVI Z9Lh00TzKVKJsSgKIbJUV9QRYaRAGmGSC+eENWNSRnQpt6i9TBlXq6ERQyOJfyBSTr 4m2IqJPDAsABt4fgQCdtvFKr7jQ48XVmz8wcn+E0= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id CD6EA6EC55 for ; Wed, 8 Sep 2021 00:59:59 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org CD6EA6EC55 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1mNj8J-00024k-2v; Wed, 08 Sep 2021 00:59:59 +0300 To: imeevma@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: <38ac1b8d1ecae3352b8fe748def9e8a451239b9a.1630915850.git.imeevma@gmail.com> Message-ID: <4e091d79-84c5-9ba1-f624-185cfced6591@tarantool.org> Date: Tue, 7 Sep 2021 23:59:58 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <38ac1b8d1ecae3352b8fe748def9e8a451239b9a.1630915850.git.imeevma@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD91AE02D33A9C88A2FECE56E2A292C9F7D3C69CC5C84EEB3A800894C459B0CD1B9DB4B867B6E92676FDDFE9FF119EBF5E2DE996B6E0ADC99F2F7B622F40FDBB785 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7D4A169723F56FEDEEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006374FA524FBD8B89EAA8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8AE09E14EF632E7DA55A99AC822EC26B9117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC974A882099E279BDA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD186FD1C55BDD38FC3FD2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6A1DCCEB63E2F10FB089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B50535A768B963B018EC3DCE6C85393D111B X-C1DE0DAB: 0D63561A33F958A5C537D33732D1A14825CEFC0A495CA23B21C880104D46A8B1D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA752546FE575EB473F1410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D343F22CE0A71FDB37E17EC2B57A2C9DE93EDEB4F76E9DBDC23F1C03F777F873C0343A4D65A16AF30BF1D7E09C32AA3244C04DC86EF0171FA944F29E99ED6C4FEBF60759606DA2E136A729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojSvkey75OmIqw31nWW8qsaw== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D0312A998AA21DF8F3D9AEE9E938D55E63841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 1/1] schema: remove assert on wrong insert into _priv X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the patch! See 4 comments below. On 06.09.2021 10:11, imeevma@tarantool.org wrote: > Prior to this patch, an assertion was throwed if a tuple with an 1. throwed -> thrown. > incorrect id was inserted into the _priv system space. This bug > appeared only in the debug build. > > Closes #6295 > --- > https://github.com/tarantool/tarantool/issues/6295 > https://github.com/tarantool/tarantool/tree/imeevma/gh-6295-assert-on-insert-with-wrong-id 2. Could you please add a changelog? > diff --git a/test/box-tap/gh-6295-assert-on-wrong-id.test.lua b/test/box-tap/gh-6295-assert-on-wrong-id.test.lua > new file mode 100755 > index 000000000..e4822f395 > --- /dev/null > +++ b/test/box-tap/gh-6295-assert-on-wrong-id.test.lua > @@ -0,0 +1,34 @@ > +#!/usr/bin/env tarantool > + > +local tap = require('tap') > +local test = tap.test('gh-6295-assert-on-wrong-id') > + > +test:plan(5) > + > +local ok, res > + > +box.cfg{} > + > +-- Should be an error, not an assertion. > +local _priv = box.space._priv > +local errmsg = "Function '1000000' does not exist" > +ok, res = pcall(_priv.replace, _priv, {1, 2, 'function', 1000000, box.priv.A}) > +test:is_deeply({ok, tostring(res)}, {false, errmsg}, "Function exists") 3. Shouldn't the message be like a comment? Describing the correct behaviour. It is printed always along with ok/no ok in the tap output. So it should be about what is expected. > diff --git a/test/box-tap/suite.ini b/test/box-tap/suite.ini > index b09d7db4f..fd55d5d24 100644 > --- a/test/box-tap/suite.ini > +++ b/test/box-tap/suite.ini > @@ -3,7 +3,7 @@ core = app > description = Database tests with #! using TAP > is_parallel = True > use_unix_sockets_iproto = True > -release_disabled = errinj_set_with_enviroment_vars.test.lua > +release_disabled = errinj_set_with_enviroment_vars.test.lua, gh-6295-assert-on-wrong-id.test.lua 4. Why? The test does not pass in release? > config = suite.cfg > fragile = { > "retries": 10, >