From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 5ED3530252 for ; Wed, 5 Dec 2018 15:34:41 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id A0VQmn4-Z8MN for ; Wed, 5 Dec 2018 15:34:41 -0500 (EST) Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 1DE6730247 for ; Wed, 5 Dec 2018 15:34:41 -0500 (EST) Subject: [tarantool-patches] Re: [PATCH v1 1/1] box: collation banchmark. From: Vladislav Shpilevoy References: <562b0a54-4369-625a-7827-566f3cbb644a@tarantool.org> Message-ID: <4db336d8-16f7-9d81-bc03-492951303393@tarantool.org> Date: Wed, 5 Dec 2018 23:34:38 +0300 MIME-Version: 1.0 In-Reply-To: <562b0a54-4369-625a-7827-566f3cbb644a@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: imeevma@tarantool.org, tarantool-patches@freelists.org, Konstantin Osipov Oh, sorry. I found how to run. And my results are the same - very little difference floating back and forth. Almost the same. Even before the patch it was a dubious idea if we need to change collations in any way. But now for me it is clear. I do not think that we need to do anything about 3573 and it should be wontfix. But as usual it is up to Kostja. On 05/12/2018 23:26, Vladislav Shpilevoy wrote: > Hi! Thanks for the bench! > > I caught this: > > vshpilevoy:test v.shpilevoy$ ./unit/coll_bench.test > Language: Eng > Assertion failed: (i == size), function reading, file /Users/v.shpilevoy/Work/Repositories/tarantool/test/unit/coll_bench.cpp, line 58. > Abort trap: 6 > > I just run the bench, nothing more. >