From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id E32FB276CA
	for <tarantool-patches@freelists.org>; Mon, 16 Jul 2018 06:31:16 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id qrPXJ8ROw6ed for <tarantool-patches@freelists.org>;
	Mon, 16 Jul 2018 06:31:16 -0400 (EDT)
Received: from smtp46.i.mail.ru (smtp46.i.mail.ru [94.100.177.106])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 9BF92276C8
	for <tarantool-patches@freelists.org>; Mon, 16 Jul 2018 06:31:16 -0400 (EDT)
Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: disallow division by
 zero
References: <2635b57f7537de386915fcac4d3fa6e10255f87a.1531394137.git.kshcherbatov@tarantool.org>
 <50125917-283f-11a9-5849-5026efd17cef@tarantool.org>
 <04f25851-5856-51fb-9d45-2af6561872a8@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <4da7fc59-0cd0-f2a0-ace6-1e3c71435cab@tarantool.org>
Date: Mon, 16 Jul 2018 13:31:04 +0300
MIME-Version: 1.0
In-Reply-To: <04f25851-5856-51fb-9d45-2af6561872a8@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>, tarantool-patches@freelists.org

Thanks for the fixes!

LGTM.

On 13/07/2018 14:49, Kirill Shcherbatov wrote:
> Hi! Thank you for review.
> 
>> 1. Typo.
> Fixed.
> 
>> 2. Garbage comment.Dropped. It wasn't mine.
> 
>> 3. Such huge test for division by zero is overkill. Please, fix the test to
>> avoid division by zero. Obviously it was not about divisions.
> Ok, I've changed one sign to fix this test case:
> return test:execsql "SELECT f+case when 17-t1.f in (select ~count(distinct (abs((abs(c)/abs(c)))/abs((abs(11)/abs(+case  .....
> return test:execsql "SELECT f+case when 17-t1.f in (select ~count(distinct (abs((abs(c)/abs(c)))/abs((abs(11)*abs(+case  .....
> Test result didn't change.
>