From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id AD8EB6BD2D; Tue, 13 Apr 2021 02:38:25 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org AD8EB6BD2D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1618270705; bh=DSy8KarsTTjOw07Uwd8yg1jXGGTIpwJxJOR5sTqQGFY=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=usRTIXCJGuB4RKM2z23HOe8MVinmC8hofNi5gK0K4v1QZvG7uhrcN8Hn+8hKpy8kK JaUqP3GiO2f7mHT3f5DCP7DaZf6E/CtmH7sDCgSmWEdmf086PL3OQM80QelLi4qRit 9mDQPQ3aBo6DjWLDlXCf2wiiU3WQ2GYUhk05o+Vs= Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 427F56BD28 for ; Tue, 13 Apr 2021 02:38:20 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 427F56BD28 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1lW68J-0005t0-Ja; Tue, 13 Apr 2021 02:38:19 +0300 To: imeevma@tarantool.org, tsafin@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: <05413fe121d62c5163593436df9fc8f1a7d2c295.1617984948.git.imeevma@gmail.com> Message-ID: <4da58298-a3b1-f4fd-c95c-955b1a0a41ad@tarantool.org> Date: Tue, 13 Apr 2021 01:38:18 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <05413fe121d62c5163593436df9fc8f1a7d2c295.1617984948.git.imeevma@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD92FFCB8E6708E748094FADAEB10E66ADA4C48BE3C291E66DA182A05F538085040467A2D161C60F7E98852ECC1A899989E11B35F9D1B25D70911C092A87D853C3F X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE75644E22E05AA81AEB287FD4696A6DC2FA8DF7F3B2552694A4E2F5AFA99E116B42401471946AA11AF1661749BA6B97735F74E19BB637114CF8F08D7030A58E5ADC58D69EE07B14084F39EFFDF887939037866D6147AF826D87382F6E514C5D23A41FEF41C9D1F3084117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC60CDF180582EB8FBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352026055571C92BF10FF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6A45692FFBBD75A6A089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C97831E00599780DECE58D86445F3BB20A73D6 X-C1DE0DAB: 0D63561A33F958A53DA0F3625E78BBCE649EFD191062BAACF849D7E181E392FED59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3453037B563866572131537F28826619CA42982EDB37A08E1EFA31E76C868F64D7335635C7A4792D981D7E09C32AA3244C8BCC818C0C64BCA337F33C72722FDCAFE3D93501275E802FFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojq8JA+pXcDukBlAN519XvEA== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822D83FE62508CA5EC9ADDECBFF69A0DC1C3841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v5 37/52] sql: introduce mem_set_null_clear() X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Nice fixes! > diff --git a/src/box/sql/vdbe.c b/src/box/sql/vdbe.c > index 7f1e0bcbe..4566606d7 100644 > --- a/src/box/sql/vdbe.c > +++ b/src/box/sql/vdbe.c > @@ -855,7 +855,7 @@ case OP_String: { /* out2 */ > * is less than P2 (typically P3 is zero) then only register P2 is > * set to NULL. > * > - * If the P1 value is non-zero, then also set the MEM_Cleared flag so that > + * If the P1 value is non-zero, then also set the Cleared flag so that The flag is still here. If you didn't remove it, I would propose to keep its mentions in the comments. > * NULL values will not compare equal even if SQL_NULLEQ is set on > * OP_Ne or OP_Eq. > */