From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <arkholga@tarantool.org>
Received: from smtp41.i.mail.ru (smtp41.i.mail.ru [94.100.177.101])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 78999469710
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 27 May 2020 13:04:15 +0300 (MSK)
References: <20200429122038.53296-1-arkholga@tarantool.org>
 <20200525130329.GI5455@tarantool.org>
 <76366f3a-19e4-f039-b84e-670e065d74a0@tarantool.org>
 <20200526160037.GO5455@tarantool.org>
From: Olga Arkhangelskaia <arkholga@tarantool.org>
Message-ID: <4d4f3731-83a1-6648-46fe-619ad8f12a46@tarantool.org>
Date: Wed, 27 May 2020 13:04:14 +0300
MIME-Version: 1.0
In-Reply-To: <20200526160037.GO5455@tarantool.org>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
Subject: Re: [Tarantool-patches] [PATCH] core: don't start example instance
 in postinstall
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Igor Munkin <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi!

I have removed @ChangeLog from commit message.

I guess I jut leave it here:

@ChangeLog:
  * Do not start example instance on 3301 port after tarantool installation
   from Debian/Ubuntu repo.


26.05.2020 19:00, Igor Munkin пишет:
> Olya,
>
> Thanks, but I have last (but not least) nit: a ChangeLog entry need to
> be plased aside from the commit message, i.e. under three dashes or in a
> cover letter. Please adjust your commit message regarding this remark.
>
> On 25.05.20, Olga Arkhangelskaia wrote:
>> Hi Igor!
>>
>> Have fixed commit message:
>>
>>    After tarantool installation on Debian/Ubuntu from repo, example instance
>>    was automatically started on 3301 port. At the same time example instance
>>    on RHEL/CentOS is started manually. Patch does the same for
>> Debian/Ubuntu.
>>
>>     Closes #4507
>>
>>     @TarantoolBot document
>>     Title: manage example instance after installation
>>     After tarantool installation from repos on all distros example instance
>>     should be managed manually.
>>
>>    @ChangeLog:
>>     * Do not start example instance on 3301 port after tarantool
>> installation
>>     from Debian/Ubuntu repo.
>>
> <snipped>
>