From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id A38184696C3
 for <tarantool-patches@dev.tarantool.org>;
 Fri,  3 Apr 2020 02:47:43 +0300 (MSK)
References: <9a402676dbab6bdc4b1cbbdfc1f5069214fdfa06.1584707598.git.imeevma@gmail.com>
 <876090db-cb61-0c46-427a-d5a856fad4f1@tarantool.org>
 <20200330113805.GA18954@tarantool.org> <20200330165313.GA14800@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <4d11ccea-2520-787b-de42-e2fdcaa4fec4@tarantool.org>
Date: Fri, 3 Apr 2020 01:47:41 +0200
MIME-Version: 1.0
In-Reply-To: <20200330165313.GA14800@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v1 1/1] sql: remove implicit cast
 for COMPARISON
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Mergen Imeev <imeevma@tarantool.org>, Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

>>>> diff --git a/src/box/sql/sqlInt.h b/src/box/sql/sqlInt.h
>>>> index 1579cc9..cd626bd 100644
>>>> --- a/src/box/sql/sqlInt.h
>>>> +++ b/src/box/sql/sqlInt.h
>>>> @@ -1304,6 +1304,9 @@ enum trim_side_mask {
>>>>  				 (X) == FIELD_TYPE_UNSIGNED || \
>>>>  				 (X) == FIELD_TYPE_DOUBLE)
>>>>  
>>>> +#define sql_mp_type_is_numeric(X)  ((X) == MP_INT || (X) == MP_UINT || \
>>>> +				    (X) == MP_FLOAT || (X) == MP_DOUBLE)
>>>
>>>
>>> 7. Is there a ticket to stop conveting MEM_* to MP_*?
>>
>> Hm, I thought I created once such ticket, but in fact failed to
>> find it. If you are OK with suggestion below concerning splitting
>> mem type into two members, I'll open an issue.
>>
> Does anyony mind if I do all this here, before main patch-set?

I am ok with that. But you need to do it quick then, because
the release is close.