From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id F26FE2500A
	for <tarantool-patches@freelists.org>; Tue, 13 Aug 2019 04:26:09 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id gmDlpChI18uW for <tarantool-patches@freelists.org>;
	Tue, 13 Aug 2019 04:26:09 -0400 (EDT)
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id B366524FEC
	for <tarantool-patches@freelists.org>; Tue, 13 Aug 2019 04:26:09 -0400 (EDT)
Subject: [tarantool-patches] Re: [PATCH v2 2/8] sql: GREATEST, LEAST
 instead of MIN/MAX overload
References: <cover.1565275469.git.kshcherbatov@tarantool.org>
 <7f7013d0209f432eb1ea12d897527ed9885c3599.1565275469.git.kshcherbatov@tarantool.org>
 <7C46701C-8D18-4433-9CD4-5B23FD6D7004@tarantool.org>
From: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Message-ID: <4ce1b183-e56c-4d70-34a2-e2215f1e7d85@tarantool.org>
Date: Tue, 13 Aug 2019 11:26:06 +0300
MIME-Version: 1.0
In-Reply-To: <7C46701C-8D18-4433-9CD4-5B23FD6D7004@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: "n.pettik" <korablev@tarantool.org>, Tarantool MailList <tarantool-patches@freelists.org>

> So, basically this patch does two things: renames existing
> scalar min/max funcs and reserves names for them in NoSQL
> cache. Please, explicitly outline these facts in commit message.
> Also, I guess name change should be documented.
Fixed. 

> 
>> Moreover it is an important stem to get rid of function's name
> 
> Nit: stem -> step.
FIxed.

> Does this patch come in scope of 2.2.2?
> I thought that it will be part of 2.3.1 (at least
> issues to be closed are related to 2.3).
> 
> The rest is OK.
Fixed.