From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Evgeniy Temirgaleev <e.temirgaleev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] test: disabled flaky test for OSX/ARM64
Date: Tue, 29 Sep 2026 14:22:27 +0300 [thread overview]
Message-ID: <4cce329e-12eb-43fc-a03d-98f901e97e57@tarantool.org> (raw)
In-Reply-To: <528c3aa4-cd63-47d1-9959-6e9ff794adfb@tarantool.org>
Hi, Evgeniy,
On 9/29/26 13:31, Evgeniy Temirgaleev wrote:
> Hi, Sergey! Thanks for review. Please, see my answers below.
>
> The branch is force pushed with new commit message.
>
> 28.09.2026 15:45, Sergey Bronnikov пишет:
>> Hello, Evgeniy!
>>
>> Thanks for the patch! LGTM with minor comments below.
>>
>> Sergey
>>
>> On 9/28/26 09:42, Evgeniy Temirgaleev wrote:
>>> From: Temir Galeev <temir.galeev@bk.ru>
>>>
>>> The test `fix-mips64-spare-side-exit-patching.test.lua`
>>> is flaky on OSX and ARM64.
>>>
>>> The problem is in the limited range for mcode chunk's
>>> addresses on ARM64 and in the OSX strategy for `mmap`
>>> to ignore user's hint [1].
>> The commit message should contain a trailer "Closes tarantool/
>> tarantool#13261", right?
>
> None. The ticket is more general. It's about mcode allocation problem
> due to address range limitation.
Then you can add "Relates to tarantool/ tarantool#13261".
>
> Updated the commit description.
>
>
<snipped>
next prev parent reply other threads:[~2026-09-29 11:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 6:42 Evgeniy Temirgaleev via Tarantool-patches
2026-09-28 12:45 ` Sergey Bronnikov via Tarantool-patches
2026-09-29 10:31 ` Evgeniy Temirgaleev via Tarantool-patches
2026-09-29 11:22 ` Sergey Bronnikov via Tarantool-patches [this message]
2026-09-29 13:10 ` Evgeniy Temirgaleev via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4cce329e-12eb-43fc-a03d-98f901e97e57@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=e.temirgaleev@tarantool.org \
--cc=sergeyb@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit] test: disabled flaky test for OSX/ARM64' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox