From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id CFE786EC40; Tue, 1 Jun 2021 17:02:37 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org CFE786EC40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1622556157; bh=GYZJWzKVs6naRK6gQGK3aRvl6bjpGxTHEfZzZ0y+Fg8=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=aNoSfCTLQlz3Cks0zFCRZJtzNz6Vuk1q7svOX6INqNj2oPYWyxPoOYhWqVhKfj+1M JuH8nuHw+WJ26O/hx5tIFfSUidQd2dGeIkw96nEuX/30ez9E/gBIVUGgIQHPxUX+oG RnaodnNp4pAE1+B6gEh+LWFD+WvtAqKcLaQyB1Y4= Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 25E9A6EC40 for ; Tue, 1 Jun 2021 17:02:36 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 25E9A6EC40 Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1lo4yZ-0004OO-74; Tue, 01 Jun 2021 17:02:35 +0300 To: Timur Safin Cc: tarantool-patches@dev.tarantool.org References: Message-ID: <4c9c6d3f-78e7-d19e-bb54-868d3b469d13@tarantool.org> Date: Tue, 1 Jun 2021 17:02:34 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9D5B0DA836B685C546075B3437CB362FF47FF2EE3FBA69D6F182A05F53808504021F4249F39E4FCEC43E0A0EF1EAD47F48A0425E1BBEA6A97DD9A45693DBD3D3C X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE75263010198C72082EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AF379580E0D677568638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8A20192934B57A58285245C79C746F46B117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC8C7ADC89C2F0B2A5A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18CB629EEF1311BF91D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B66F6A3E018CF4DC80089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A50A8B3DF99A1684F1E5ACBA7DACCBB3890D9C83B1A808885AD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75FBC5FED0552DA851410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D345DE7771146E56B08303B3F1EB1DAB33032394B344B8500D005BE2D6544440BD4DB9F66C5B1D4950C1D7E09C32AA3244C2CE9F5EA7F12873974DEB342D3EA53EF7101BF96129E4011729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojt1KCq4WZgK4PhV7rF+Z4MA== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822336A9B2BF7BE7FE87365C82C8DE837C283D72C36FC87018B9F80AB2734326CD2FB559BB5D741EB96352A0ABBE4FDA4210A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 0/3] sql: modify explicit conversion tables X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mergen Imeev via Tarantool-patches Reply-To: Mergen Imeev Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thank you for the patch-set. See 6 comments below. 0. In general, I want to say that I do not like your style of commit-messages. I think there are too many unnecessary words and constructions in it. But that's just my opinion. I have not seen any rules prohibiting this. 1. Why "tables" in name of the patch? I see only one table. On Tue, May 25, 2021 at 12:00:59PM +0300, Timur Safin wrote: > > Recent RFC "Consistent Lua/SQL types" (#6009) defined ideal explicit > and implicit conversion tables we would like to have for all current > and future Taranool SQL types. > 2. Why do you need number of pull-request here? I mean, you already have a name of RFC. > This patchset modifies explict conversion tables, and implicit 3. Here should be "explicit" I believe. > conversion table to come soon. The ideal picture would be as below: > > | 0 | 1 | 2 | 4 | 5 | 6 | 7 | 3 | 9 |10 |11 |12 | 8 | > +---+---+---+---+---+---+---+---+---+---+---+---+---+ > 0. any | | | | | | | | | | | | | | > 1. unsigned | | Y | Y | Y | Y | | | Y | | | | | Y | > 2. string | | S | Y | S | S | S | Y | S | | | | | Y | > 4. double | | S | Y | Y | S | | | Y | | | | | Y | > 5. integer | | S | Y | Y | Y | | | Y | | | | | Y | > 6. boolean | | | Y | | | Y | | | | | | | Y | > 7. varbinary | | | Y | | | | Y | | | | | | Y | > 3. number | | S | Y | Y | S | | | Y | | | | | Y | > 9. decimal | | | | | | | | | | | | | | > 10. uuid | | | | | | | | | | | | | | > 11. array | | | | | | | | | | | | | | > 12. map | | | | | | | | | | | | | | > 8. scalar | | S | Y | S | S | S | S | S | | | | | Y | > +---+---+---+---+---+---+---+---+---+---+---+---+---+ > 4. Why there is such strange order in table? Also, I believe it makes sense to describe what "S", "Y" means and why some cells are empty. > Please pay attention that we omit DECIMAL, UUID, SCALAR and MAP rows > and columns, as they not yet fully supported by Tarantool SQL. Once > their support will be landed we will modify conversion table and > tests (which we also introducing with current patchset). > 5. Why not drop them if they are omitted? I mean, "modify" in name of the letter means that you change existing rules. 6. Please include links to issue and branch in cover-letter. > > Timur Safin (3): > sql: fixes for boolean expressions in explicit converstion tables > sql: enabled ANY as target for explicit conversions > sql: introduced explicit casts test e_casts.test.lua > > extra/mkkeywordhash.c | 3 +- > src/box/sql/mem.c | 39 +--- > src/box/sql/parse.y | 3 +- > test/sql-tap/cse.test.lua | 12 +- > test/sql-tap/e_casts.test.lua | 355 ++++++++++++++++++++++++++++++++ > test/sql-tap/e_select1.test.lua | 2 +- > test/sql-tap/in1.test.lua | 16 +- > test/sql-tap/keyword1.test.lua | 2 +- > test/sql-tap/misc3.test.lua | 2 +- > test/sql/boolean.result | 38 +--- > test/sql/types.result | 14 +- > 11 files changed, 390 insertions(+), 96 deletions(-) > create mode 100755 test/sql-tap/e_casts.test.lua > > -- > 2.29.2 >